Repository navigation
chore(site): remove dead code and an import cycle - #31690
Draft
DanielleMaywood wants to merge 1 commit into
Draft
DanielleMaywood wants to merge 1 commit into
DanielleMaywood wants to merge 1 commit into
Conversation
Delete an unused script and two unused __mocks__ files, remove unused class members and the unread workspaceCount prop, import useChatStore directly to break the chatStore cycle, rename the local SkillMetadata to SkillSummary so it no longer shadows the generated type, and move @coder/pixel-storybook to dependencies because Spinner.tsx imports it.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes dead code and an import cycle that fallow reports and knip does not, so that #31634 can replace knip and still pass on
main. Behavior does not change.scripts/warmup-storybook-cache.mjs. chore(Makefile): drop test-storybook from pre-push #29078 removed its only caller, in the Makefile.src/__mocks__/{js-untar,monaco-editor}.ts. Vitest does not readsrc/__mocks__, and no test callsvi.mockfor these modules.SmoothTextEngine.resetandTarReader.getFileBlob, and the private helper that onlygetFileBlobcalled.workspaceCountprop ofAgentCreateForm. The component never read it.chatStore.tsanduseChatStore.ts: drop the re-export and importuseChatStoredirectly.SkillMetadatatoSkillSummary, nowPick<SkillMetadata, "name" | "description">, so it no longer has the same name as the generated type.exportfromloadRedirects, which only its own file uses.@coder/pixel-storybooktodependencies, becausesrc/components/Spinner/Spinner.tsximports it.Stacked on #31689. #31634 is stacked on this PR.