Repository navigation
chore(Makefile): drop test-storybook from pre-push - #29078
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the test-storybook target (and its cache warmup step) from the pre-push aggregate.
The storybook vitest run has repeatedly stalled or failed for developers running pre-push. PR #24703 already tried to fix this by serializing the storybook phase after the parallel Go test, JS test, and site build phases, and it still keeps failing.
Storybook coverage is not lost: CI runs the storybook job (storybook:build plus Pixel snapshots for trusted runs) on every PR.
The standalone make test-storybook target remains available for running the suite outside pre-push.