Repository navigation
refactor: rename prepareGeneration to buildTurnEnvironment - #30866
Merged
ibetitsmike merged 1 commit intoOct 16, 2026
Merged
Conversation
ibetitsmike
added this pull request to stack #30871
October 15, 2026 17:42
This was referenced Oct 15, 2026
ibetitsmike
marked this pull request as ready for review
October 15, 2026 17:43
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
hugodutka
approved these changes
Oct 16, 2026
ibetitsmike
added a commit
that referenced
this pull request
Oct 16, 2026
…ilter (#30864) Removes `allowedBehaviorToolNames`, `allToolNames`, and `TestAllowedBehaviorToolNames`, and the active-name check they fed in `appendDynamicTools`. The check never skipped a tool. `appendDynamicTools` returns early for Explore mode and plan mode, so at the check, `allowedBehaviorToolNames` always returned every tool name. A dynamic tool that shares a built-in tool's name is still dropped with a warning. Validation: `go test ./coderd/x/chatd/ -run 'Dynamic|AllowedExplore|StopAfterPlan'` passes, and the pre-commit hook (build, `lint/go`, `lint/go/new-code`) passed. ## Stack This stack splits #28757, as requested in review. It moves the code that prepares a chat turn into one file, `turn_environment.go`, and moves the tool policy tests from full turns to a table test. chatd behaves as on `main`, except for the debug log in #30865. 1. #30864 Remove the no-op `allowedBehaviorToolNames` filter 2. #30865 Log workspace agent lookup errors in turn preparation 3. #30866 Rename `prepareGeneration` to `buildTurnEnvironment` 4. #30867 Cover the turn tool policy at `buildTurnEnvironment` 5. #30868 Remove seven end-to-end tool policy tests 6. #30869 Name the `*Server` receiver `p` in `turn_environment.go` 7. #30870 Move the turn preparation helpers into `turn_environment.go` > Xum, an AI agent, opened this PR for @ibetitsmike and wrote this description.
ibetitsmike
force-pushed
the
mike/chatd-turn-env-split/rename-turn-environment
branch
from
October 16, 2026 20:44
6468b12 to
b04083d
Compare
Base automatically changed from
mike/chatd-turn-env-split/log-agent-lookup-error
to
main
October 16, 2026 20:59
ibetitsmike
added a commit
that referenced
this pull request
Oct 16, 2026
…aration (#30865) Logs the error from `getWorkspaceAgent` at debug level in turn preparation. `prepareGeneration` discarded it. The turn still goes on without the agent, as before. The agent only adds its OS and working directory to the instruction header. Validation: build and vet pass, and the pre-commit hook passed. ## Stack This stack splits #28757, as requested in review. It moves the code that prepares a chat turn into one file, `turn_environment.go`, and moves the tool policy tests from full turns to a table test. chatd behaves as on `main`, except for the debug log in #30865. 1. #30864 Remove the no-op `allowedBehaviorToolNames` filter 2. #30865 Log workspace agent lookup errors in turn preparation 3. #30866 Rename `prepareGeneration` to `buildTurnEnvironment` 4. #30867 Cover the turn tool policy at `buildTurnEnvironment` 5. #30868 Remove seven end-to-end tool policy tests 6. #30869 Name the `*Server` receiver `p` in `turn_environment.go` 7. #30870 Move the turn preparation helpers into `turn_environment.go` > Xum, an AI agent, opened this PR for @ibetitsmike and wrote this description.
Rename the turn preparation step after what it returns, the environment for one turn: - generation_preparer.go becomes turn_environment.go, and its test file becomes turn_environment_internal_test.go. The site test comment that points at that test file follows the rename. - prepareGeneration becomes buildTurnEnvironment, and its result type generationPrepared becomes turnEnvironment. - The exported-looking Cleanup field becomes an unexported cleanup field behind a Close method that does nothing on a zero value.
ibetitsmike
force-pushed
the
mike/chatd-turn-env-split/rename-turn-environment
branch
from
October 16, 2026 20:59
b04083d to
069bc89
Compare
ibetitsmike
deleted the
mike/chatd-turn-env-split/rename-turn-environment
branch
October 16, 2026 21:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames the turn preparation step after what it returns: the environment for one turn. Only names change, plus one small change to how callers release the environment.
generation_preparer.gobecomesturn_environment.go, and its test file becomesturn_environment_internal_test.go. GitHub shows both as renames. A comment incompactionTriggers.test.tsthat names the test file follows the rename.prepareGenerationbecomesbuildTurnEnvironment, and its result typegenerationPreparedbecomesturnEnvironment. FourTestPrepareGeneration*tests becomeTestBuildTurnEnvironment*.Cleanupfield becomes the unexportedcleanup, and callers useClose().Close()does nothing on a zero value.The type stays in
generation.gofor now. #30870 moves it next tobuildTurnEnvironment.Validation: build and vet pass, the renamed tests and the
toolinputtests pass, and the pre-commit hook passed.Stack
This stack splits #28757, as requested in review. It moves the code that prepares a chat turn into one file,
turn_environment.go, and moves the tool policy tests from full turns to a table test. chatd behaves as onmain, except for the debug log in #30865.allowedBehaviorToolNamesfilterprepareGenerationtobuildTurnEnvironmentbuildTurnEnvironment*Serverreceiverpinturn_environment.goturn_environment.go