Repository navigation
refactor(coderd/x/chatd): remove the no-op allowedBehaviorToolNames filter - #30864
Merged
ibetitsmike merged 1 commit intoOct 16, 2026
Merged
Conversation
…ilter appendDynamicTools returns early for Explore mode and plan mode, so allowedBehaviorToolNames always returned every tool name and the active-name filter in front of the collision check skipped nothing.
ibetitsmike
added this pull request to stack #30871
October 15, 2026 17:42
This was referenced Oct 15, 2026
ibetitsmike
marked this pull request as ready for review
October 15, 2026 17:43
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
hugodutka
approved these changes
Oct 16, 2026
ibetitsmike
deleted the
mike/chatd-turn-env-split/remove-noop-tool-filter
branch
October 16, 2026 20:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
allowedBehaviorToolNames,allToolNames, andTestAllowedBehaviorToolNames, and the active-name check they fed inappendDynamicTools.The check never skipped a tool.
appendDynamicToolsreturns early for Explore mode and plan mode, so at the check,allowedBehaviorToolNamesalways returned every tool name. A dynamic tool that shares a built-in tool's name is still dropped with a warning.Validation:
go test ./coderd/x/chatd/ -run 'Dynamic|AllowedExplore|StopAfterPlan'passes, and the pre-commit hook (build,lint/go,lint/go/new-code) passed.Stack
This stack splits #28757, as requested in review. It moves the code that prepares a chat turn into one file,
turn_environment.go, and moves the tool policy tests from full turns to a table test. chatd behaves as onmain, except for the debug log in #30865.allowedBehaviorToolNamesfilterprepareGenerationtobuildTurnEnvironmentbuildTurnEnvironment*Serverreceiverpinturn_environment.goturn_environment.go