Skip to content

docs: correct nginx X-Forwarded-Proto and certbot instructions flavor (#28086) - #28160

Merged
nickvigilante merged 1 commit into
release/2.29from
backport/28086-to-2.29
Aug 14, 2026
Merged

docs: correct nginx X-Forwarded-Proto and certbot instructions flavor (#28086)#28160
nickvigilante merged 1 commit into
release/2.29from
backport/28086-to-2.29

Conversation

@github-actions

Copy link
Copy Markdown

Backport of #28086

Original PR: #28086 — docs: correct nginx X-Forwarded-Proto and certbot instructions flavor
Merge commit: b0e93b6
Requested by: @nickvigilante

…#28086)

## What

Two fixes to the nginx reverse-proxy tutorial.

### `X-Forwarded-Proto` (line 137)
The config set:
```nginx
proxy_set_header X-Forwarded-Proto $http_x_forwarded_proto;
```
`$http_x_forwarded_proto` is the value of a client-supplied request
header, which a client can spoof and which is usually empty for a direct
request. In an nginx TLS-terminating reverse proxy this should be
`$scheme`, which nginx sets from the actual connection (`https`). Using
the raw client header can break Coder's scheme detection and
secure-cookie handling.

### Certbot link flavor (line 57)
The Certbot instructions link used `?ws=apache` in an nginx guide;
changed to `?ws=nginx` so readers get nginx instructions.

Surfaced by the runtime drift sweep; verified against `main`.

Linear:
[DOCS-642](https://linear.app/codercom/issue/DOCS-642/docs-fix-reverse-proxy-nginx-x-forwarded-proto-dollarscheme-certbot)

> This PR was created with AI assistance (Coder Agents).

(cherry picked from commit b0e93b6)
@nickvigilante
nickvigilante merged commit 8a49478 into release/2.29 Aug 14, 2026
@nickvigilante
nickvigilante deleted the backport/28086-to-2.29 branch August 14, 2026 16:54
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/v2.29 Backport PR targeting release/2.29

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant