docs: correct nginx X-Forwarded-Proto and certbot instructions flavor - #28086
Draft
nickvigilante wants to merge 1 commit into
Draft
docs: correct nginx X-Forwarded-Proto and certbot instructions flavor#28086nickvigilante wants to merge 1 commit into
nickvigilante wants to merge 1 commit into
Conversation
reverse-proxy-nginx.md set X-Forwarded-Proto from $http_x_forwarded_proto, a client-controlled (spoofable) header. In an nginx TLS-terminating reverse proxy it should be $scheme, which nginx derives from the actual connection. Also point the Certbot instructions link at the nginx flavor (ws=nginx) instead of apache. Fixes DOCS-642. > This PR was created with AI assistance (Coder Agents).
Docs previewCheck off each page once it's been reviewed. If a page changes in a later push, its checkbox clears automatically so it gets a fresh look. Pages not yet wired into the docs navigation aren't listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two fixes to the nginx reverse-proxy tutorial.
X-Forwarded-Proto(line 137)The config set:
$http_x_forwarded_protois the value of a client-supplied request header, which a client can spoof and which is usually empty for a direct request. In an nginx TLS-terminating reverse proxy this should be$scheme, which nginx sets from the actual connection (https). Using the raw client header can break Coder's scheme detection and secure-cookie handling.Certbot link flavor (line 57)
The Certbot instructions link used
?ws=apachein an nginx guide; changed to?ws=nginxso readers get nginx instructions.Surfaced by the runtime drift sweep; verified against
main.Linear: DOCS-642