feat(site): show org default roles in member role editor#26107
Open
Emyrk wants to merge 3 commits into
Open
Conversation
This was referenced Jun 5, 2026
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
DanielleMaywood
approved these changes
Jun 5, 2026
d2af057 to
a562e74
Compare
9fa32a5 to
a67d838
Compare
ff31cc0 to
ba009dc
Compare
a67d838 to
238f18b
Compare
ba009dc to
7c41dd8
Compare
238f18b to
8a535b1
Compare
7c41dd8 to
a7e73e1
Compare
8a535b1 to
56220d5
Compare
a7e73e1 to
fc88284
Compare
56220d5 to
206014f
Compare
When editing an organization member's roles, render the org's `default_org_member_roles` as additional always-granted (implied) rows below `Member`. The roles are also filtered out of the selectable list since they cannot be toggled off. Other surfaces (deployment users, user create, the org Roles page's Default Roles editor) keep showing only `Member` as the sole implied role.
Add a small italic caption "Sourced from organization default roles" to each implied row that comes from the org's default member roles. The `Member` row keeps its existing layout (no caption).
206014f to
3a0ec37
Compare
fc88284 to
0424249
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #25936. Stacks on #26028.
Surfaces the org's
default_org_member_rolesinside the org members role editor. These roles are implied, not physically assigned to any member. Just like thememberrole.Configured in the org settings.
Implementation notes
MemberRolerow was generalized into a smallImpliedRoleRow.Memberis the first row; anyadditionalImpliedRolesfollow in order. Both share the same disabled style.DefaultRolesDialogdeliberately does not passadditionalImpliedRoles. That editor is where defaults are configured, so showing them as implied there would be circular.Coder Agents on behalf of @Emyrk.