feat(site): add Default Roles section to organization settings#26028
Open
Emyrk wants to merge 1 commit into
Open
feat(site): add Default Roles section to organization settings#26028Emyrk wants to merge 1 commit into
Emyrk wants to merge 1 commit into
Conversation
This was referenced Jun 3, 2026
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
c4a5fcc to
976957f
Compare
c91e381 to
d1ee7c9
Compare
976957f to
8ea2020
Compare
d1ee7c9 to
7813b1a
Compare
5c9c069 to
620c357
Compare
210be86 to
34ec9ef
Compare
eb10210 to
538597d
Compare
8e1cf4c to
d46be0c
Compare
538597d to
986699a
Compare
d46be0c to
0e1c45b
Compare
986699a to
8a07ffd
Compare
Adds a new Default Roles section to the org settings page (gated on the minimum-implicit-member experiment) that edits an org's default_org_member_roles via the existing PATCH endpoint. Uses the existing RoleSelector primitive via a new DefaultRolesDialog sibling. RoleSelectorDialog itself is too user-centric (avatar header, username/email props) to reuse here. Refs #25936.
0e1c45b to
b78d140
Compare
8a07ffd to
9884564
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #25936. Stacks on #26027.
Adds a
Default Rolessection to the org settings page that edits an org'sdefault_org_member_rolesvia the existing PATCH endpoint.minimum-implicit-memberexperiment viauseDashboard().experiments.RoleSelectorprimitive inside a newDefaultRolesDialog.getErrorDetailon failure.Screencast.From.2026-06-03.18-02-06.webm
Implementation notes
RoleSelectorDialogis the existing per-user role editor; it's user-centric (avatar header,username/emailprops). Wrapping it for the org-default case would have meant feeding it a synthetic "user", so this PR adds a small siblingDefaultRolesDialogand reuses the innerRoleSelectorprimitive directly. Same look, same behavior in the picker.updateOrganization→default_org_member_roles). The page reuses the existingupdateOrganizationmutation.organizationRoles(orgName)is fetched only when the experiment is enabled (useQuery({ enabled })).DefaultRolesSummaryresolves role names to display names via the fetchedAssignableRoles[], falling back to the raw name when the role is not in the list.Coder Agents on behalf of @Emyrk.