Skip to content

chore(provisioner/terraform/testdata): update provider versions, fix resource monitor tests#16601

Merged
johnstcn merged 1 commit into
colin/tf-1.10.5from
cj/colin/tf-1.10.5
Feb 18, 2025
Merged

chore(provisioner/terraform/testdata): update provider versions, fix resource monitor tests#16601
johnstcn merged 1 commit into
colin/tf-1.10.5from
cj/colin/tf-1.10.5

Conversation

@johnstcn

@johnstcn johnstcn commented Feb 18, 2025

Copy link
Copy Markdown
Member

Updates to #16519

  • Fixes missing leading / in volumes in resource monitor tests
  • Updates provider to >=2.0.0 in provider testdata
  • Fixes provider to required release version for resource monitors

@johnstcn johnstcn self-assigned this Feb 18, 2025
@johnstcn johnstcn requested review from defelmnq and mtojek February 18, 2025 11:11
@johnstcn johnstcn changed the title chore(terraform/testdata): update provider versions, fix resource monitor tests chore(provisioner/terraform/testdata): update provider versions, fix resource monitor tests Feb 18, 2025

@dannykopping dannykopping left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@mtojek mtojek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

},
Volumes: []*proto.VolumeResourceMonitor{
{
Path: "volume2",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you catch it while reviewing or did any alarm go off?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the provider just complained

@johnstcn johnstcn merged commit b770dc7 into colin/tf-1.10.5 Feb 18, 2025
@johnstcn johnstcn deleted the cj/colin/tf-1.10.5 branch February 18, 2025 11:29
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants