Skip to content

chore: upgrade terraform to 1.10.5#16519

Merged
johnstcn merged 3 commits into
mainfrom
colin/tf-1.10.5
Feb 18, 2025
Merged

chore: upgrade terraform to 1.10.5#16519
johnstcn merged 3 commits into
mainfrom
colin/tf-1.10.5

Conversation

@coadler
Copy link
Copy Markdown
Contributor

@coadler coadler commented Feb 10, 2025 •
edited by matifali
Loading

Updates terraform to v1.10.5

@coadler coadler requested a review from stirby February 10, 2025 21:28
matifali
matifali approved these changes Feb 13, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@matifali matifali left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except the testdata changes.

matifali
matifali requested changes Feb 13, 2025
View reviewed changes
Comment thread provisioner/terraform/testdata/chaining-resources/chaining-resources.tfplan.json Outdated
johnstcn
johnstcn previously requested changes Feb 14, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@johnstcn johnstcn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @matifali , not sure about those testdata changes. The rest LGTM.

@johnstcn johnstcn assigned johnstcn and unassigned coadler Feb 18, 2025
@johnstcn johnstcn mentioned this pull request Feb 18, 2025
Merged
@johnstcn
chore(provisioner/terraform/testdata): update provider versions, fix …
b770dc7 
…resource monitor tests (#16601)

Updates to #16519

- Fixes missing leading `/` in volumes in resource monitor tests
- Updates provider to `>=2.0.0` in provider testdata
- Fixes provider to required release version for resource monitors
@matifali
Copy link
Copy Markdown
Member

matifali commented Feb 18, 2025

Should rebase on main after #16601 is merged.

@johnstcn
Copy link
Copy Markdown
Member

johnstcn commented Feb 18, 2025

Should rebase on main after #16601 is merged.

I merged it into this PR!

johnstcn
johnstcn approved these changes Feb 18, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(semi-biased approval alert)

@johnstcn johnstcn merged commit a777c26 into main Feb 18, 2025
@johnstcn johnstcn deleted the colin/tf-1.10.5 branch February 18, 2025 11:45
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 18, 2025
@stirby
Copy link
Copy Markdown
Collaborator

stirby commented Feb 19, 2025

/cherry-pick release/2.19

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@SasSwart SasSwart SasSwart left review comments

@dannykopping dannykopping dannykopping approved these changes

@johnstcn johnstcn johnstcn approved these changes

@matifali matifali matifali approved these changes

@stirby stirby stirby approved these changes

@defelmnq defelmnq Awaiting requested review from defelmnq

Assignees

@johnstcn johnstcn

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@coadler @matifali @johnstcn @stirby @dannykopping @SasSwart