chore(coderd): improve tests for tar<->zip conversion#12477
Merged
Conversation
mafredri
approved these changes
Mar 8, 2024
Member
mafredri
left a comment
There was a problem hiding this comment.
Just minor nits, nice thorough tests!
| func TestCreateTarFromZip(t *testing.T) { | ||
| t.Parallel() | ||
| if runtime.GOOS != "linux" { | ||
| t.Skip("skipping this test on non-Linux platform") |
Member
Author
There was a problem hiding this comment.
Generally yes, but I'm not going to assume the presence of tar and unzip on Windows for this test :-)
This was referenced Mar 8, 2024
…to tar (#12476) * fix(coderd): set mode and modtime correctly when converting from zip->tar
mtojek
pushed a commit
that referenced
this pull request
Mar 11, 2024
* improve tests for tar<->zip conversion * set mode and modtime correctly when converting from zip to tar (#12476)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
STACK:
#12477 <-- you are here
#12476
#12475
#12479
coderd/testdataNOTE: these tests will fail until #12476 is merged in