fix(coderd): prevent nil err deref#12475
Merged
Merged
Conversation
mafredri
approved these changes
Mar 8, 2024
Member
mafredri
left a comment
There was a problem hiding this comment.
I’d omit the field entirely but LGTM!
e34a37a to
33029d7
Compare
mtojek
approved these changes
Mar 11, 2024
33029d7 to
c2b061a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
STACK:
#12477
#12476
#12475 <-- you are here
#12479
Drive-by: prevent a nil pointer deref; err should always be nil in these codepaths.