Skip to content

Commit 7b0e9b0

Browse files
dario-piotrowiczthePunderWoman
authored andcommitted
docs(animations): remove incorrect information regarding animateChild (angular#44216)
Remove incorrect information present in the angular.io animations documentation stating that animateChild does not work with route transition animations as that turned out not to be true This PR effectively reverts the changes make in PR: angular#44014 For more context see issue angular#30477 PR Close angular#44216
1 parent 6ae3858 commit 7b0e9b0

3 files changed

Lines changed: 2 additions & 18 deletions

File tree

aio/content/guide/animations.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,7 @@ What it does
289289

290290
<tr>
291291
<td><code>query()</code></td>
292-
<td>Finds one or more inner HTML elements within the current element. </td>
292+
<td>Finds one or more inner HTML elements within the current element.</td>
293293
</tr>
294294

295295
<tr>
@@ -314,7 +314,7 @@ What it does
314314

315315
<tr>
316316
<td><code>animateChild()</code></td>
317-
<td>Allows animations on child components to be run within the same timeframe as the parent. <strong>Note:</strong> Please see GitHub Issue <a href="https://github.com/angular/angular/issues/30477">#30477</a> before attempting to use <code>animateChild()</code> together with route transition animations.</td>
317+
<td>Allows animations on child components to be run within the same timeframe as the parent.</td>
318318
</tr>
319319

320320
</table>

aio/content/guide/route-animations.md

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -75,12 +75,6 @@ Animations can be defined directly inside your components. For this example you
7575

7676
The following code snippet defines a reusable animation named `slideInAnimation`.
7777

78-
<div class="alert is-important">
79-
80-
**Note:** `animateChild()` does not currently work with route transition animations. Please see GitHub Issue <a href="https://github.com/angular/angular/issues/30477">#30477</a> for more information.
81-
82-
</div>
83-
8478
<code-example path="animations/src/app/animations.ts" header="src/app/animations.ts" region="route-animations" language="typescript"></code-example>
8579

8680
The animation definition performs the following tasks:
@@ -114,12 +108,6 @@ Use the `query()` method to find and animate elements within the current host co
114108

115109
Assume that you are routing from the *Home => About*.
116110

117-
<div class="alert is-important">
118-
119-
**Note:** `animateChild()` does not currently work with route transition animations. Please see GitHub Issue <a href="https://github.com/angular/angular/issues/30477">#30477</a> for more information.
120-
121-
</div>
122-
123111
<code-example path="animations/src/app/animations.ts" header="src/app/animations.ts (excerpt)" region="query" language="typescript"></code-example>
124112

125113
The animation code does the following after styling the views:

packages/animations/src/animation_metadata.ts

100755100644
Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1114,10 +1114,6 @@ export function animation(
11141114
* with animations that are assigned using the Angular animation library. CSS keyframes
11151115
* and transitions are not handled by this API.
11161116
*
1117-
* `animateChild()` does not currently work with route transition animations. Please see
1118-
* GitHub Issue {@link https://github.com/angular/angular/issues/30477 #30477} for more
1119-
* information.
1120-
*
11211117
* @publicApi
11221118
*/
11231119
export function animateChild(options: AnimateChildOptions|null = null):

0 commit comments

Comments
 (0)