Added TimeSelect control for selecting session times, and moved const…#9863
Closed
aoby wants to merge 1 commit into
Closed
Added TimeSelect control for selecting session times, and moved const…#9863aoby wants to merge 1 commit into
aoby wants to merge 1 commit into
Conversation
…ants into workshopConstants
| "mkdirp": "0.5.1", | ||
| "mochify": "2.18.0", | ||
| "moment": "2.10.6", | ||
| "moment": "^2.14.1", |
Contributor
There was a problem hiding this comment.
I would tie to a specific version (i.e. "2.14.1" instead of "^2.14.1") so as to avoid future confusion when engineers end up on slightly different versions.
Contributor
|
Couple nit-level comments, but generally lgtm |
Contributor
Author
|
Closing in order to create a new PR with the same changes against staging (now that #9862 has been merged). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ants into workshopConstants
(this depends on #9862, so comparing to that PR for easier review).
Adds a dropdown time-select control for session start and end times:
I tested this manually on chrome, firefox, and safari.