Upgraded React-Bootstrap to the latest version and ES6-ified some code#9862
Merged
Conversation
| "react": "15.2.1", | ||
| "react-addons-test-utils": "15.2.1", | ||
| "react-bootstrap": "0.29.5", | ||
| "react-bootstrap": "^0.30.1", |
Contributor
There was a problem hiding this comment.
should we tie to exactly "0.30.1" so that we dont have to worry about different engineers ending up on slightly different versions?
Contributor
|
lgtm. very cool seeing this stuff become more ES6y :) |
- changed all vars to const (where possible) or let - removed () from single-param arrow functions - removed function declartions from render method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note - some controls in
react-bootstraphave changed, notably<Input>is nowFormControl, and some of the features that were formerly set as properties of theInputare now handlded by their own components surrounding theFormControl(e.g.FormGroup,ControlLabel,HelpBlock). See https://react-bootstrap.github.io/components.html#formsThis is a straight upgrade with no functionality difference.