DTT #2 #9772
Merged
Merged
Conversation
… "default to continue".
Gives a better default sort order in teacher view. Also add a storybook entry for teacher view.
Use a separate "Teacher View" button in the lobby to display the log browser with teacher-view features, instead of making them 'always on' for the shard owner. This lets us enable teacher view in levels where the log browser is disabled, and leaves the teacher an option for having a live log browser on the projector without revealing sender names.
Formerly, blockly blocks which appear in Top Instructions were capturing mousewheel events and preventing scrolling when the mouse was within their blockspace. Now that all ReadOnly blockspaces are being precisely sized to fit their contents, scrolling readonly blockspaces is unnecessary and their ability to scroll can safely be removed.
Deploy to levelbuilder
The script view (which is somewhat obscurely still rendered by a teacher viewing a student's progress) wasn't showing purple for submitted levels.
Fixes this warning: > Note: The code generator has deoptimised the styling of "common.js" as it exceeds the max of "100KB".
… than several individual options arguments
…ce, rather than creating then immedidately destroying them
Pseudo-blocking ask block for Play Lab
NetSim: Teacher View
Don't compact large JS build files locally (for easier debugging)
Script view wasn't showing purple for submitted level.
Fix "Replay" buttons (used in `craft` levels)
…lling-through-blockly-blocks Allow scrolling Top Instructions despite Blockly Blocks
43199a2 Merge branch 'staging' of github.com:code-dot-org/code-dot-org into staging (Continuous Integration)
Deploy to Levelbuilder from test
Levelbuilder to staging
add link to teacher's notes for mc and sw landing pages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
request from @joshlory