NetSim: Teacher View#9752
Merged
Merged
Conversation
Gives a better default sort order in teacher view. Also add a storybook entry for teacher view.
Use a separate "Teacher View" button in the lobby to display the log browser with teacher-view features, instead of making them 'always on' for the shard owner. This lets us enable teacher view in levels where the log browser is disabled, and leaves the teacher an option for having a live log browser on the projector without revealing sender names.
| `Here's what the teacher (or shard owner) gets to see`, | ||
| () => ( | ||
| <div id="netsim"> | ||
| <div className="new-router-log-modal"> |
Contributor
Author
There was a problem hiding this comment.
TODO: Remove now-unneeded wrapper div
Contributor
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a "Teacher View" that is only available from the lobby, and only to shard owners (i.e. the teacher).
Here's the button:
It's just like the log browser, but it includes a "Sent By" column listing the username for each message.
It also lets the teacher filter by "Sent By" user, which makes it easy to track a student across simulated IP addresses.
I've intentionally kept this separate from the main log browser view, which teachers may still want to project (say, during the battleship lesson) for instructional purposes. We also enable the "Teacher View" button in levels that don't have the log browser (like Battleship) to allow monitoring.
TODO