DTT (Staging > Test) with content changes#9713
Merged
Merged
Conversation
I tried just install chai-enzyme, but I got all kinds of peer dependency version complaints. So I just went ahead and updated various libraries. Most of them were minor version updates, except for chai which went from version 1.x to 3.x
Test > Levelbuilder
The new version of react started complaining about this with a warning, and react prop warnings are now turned into failures in our integration tests. Fixing this the "react way" is to use the object spread operator, which isn't officially a part of the es6 spec. But everyone just uses the corresponding babel transform plugin.
Upgrade some libraries and install chai-enzyme
implement add / rename / delete column in data browser [axot: 51]
Conflicts: apps/src/code-studio/components/progress/course_progress_row.jsx
There was a display bug when toggling whether succeeded tests were visible; after being hidden and shown again, successful test result columns did not align with failures. This is because 'inherit' is not the right display style for a <tr> element; should use `display: table-row` instead.
When we switched to automagically importing test locales, we inadvertantly broke the storybook. This fixes it by just having a separate webpack config for storybook and karma. I also went ahead and upgraded storybook, which fixes a couple bugs we were encountering.
Ui test page improvements
…nings Fix storybook webpack config
Levelbuilder > Staging
Blue box for lesson plan links
copy updates to widgets page
enable unusedBlocks everywhere
Add simple "repeat n times" blocks to playlab toolbox toolbox
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.