Upgrade some libraries and install chai-enzyme#9629
Merged
Conversation
fef3ae2 to
d0d0bb8
Compare
Contributor
|
This should be fine. It'd be nice to run the UI tests on circle though, just to get somewhat better coverage before this hits staging. Give it a shot? |
I tried just install chai-enzyme, but I got all kinds of peer dependency version complaints. So I just went ahead and updated various libraries. Most of them were minor version updates, except for chai which went from version 1.x to 3.x
2e1fd9d to
fe3522c
Compare
The new version of react started complaining about this with a warning, and react prop warnings are now turned into failures in our integration tests. Fixing this the "react way" is to use the object spread operator, which isn't officially a part of the es6 spec. But everyone just uses the corresponding babel transform plugin.
fe3522c to
f78c530
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried just install chai-enzyme, but I got all kinds of peer dependency
version complaints. So I just went ahead and updated various
libraries. Most of them were minor version updates, except for chai
which went from version 1.x to 3.x