Skip to content

fix(circular-dependencies): remove resolved i18nStringTracker cycles#73445

Merged
artem-vavilov merged 1 commit into
stagingfrom
circular-dependencies-fix
Jun 24, 2026
Merged

fix(circular-dependencies): remove resolved i18nStringTracker cycles#73445
artem-vavilov merged 1 commit into
stagingfrom
circular-dependencies-fix

Conversation

@artem-vavilov

@artem-vavilov artem-vavilov commented Jun 24, 2026

Copy link
Copy Markdown
Member 
WARNING in Circular Dependency Checker : 4 resolved circular dependencies can be removed from circular_dependencies.json :
  src/util/experiments.js -> src/utils.js -> src/util/locale-do-not-import.js -> src/util/i18nStringTracker.js -> src/util/experiments.js
  src/util/i18nStringTracker.js -> src/util/experiments.js -> src/utils.js -> src/util/locale-do-not-import.js -> src/util/i18nStringTracker.js
  src/util/locale-do-not-import.js -> src/util/i18nStringTracker.js -> src/util/experiments.js -> src/utils.js -> src/util/locale-do-not-import.js
  src/utils.js -> src/util/locale-do-not-import.js -> src/util/i18nStringTracker.js -> src/util/experiments.js -> src/utils.js

Related PR:

@artem-vavilov artem-vavilov requested review from a team and Copilot June 24, 2026 10:54
Copilot AI reviewed Jun 24, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes now-resolved circular-dependency allowlist entries in apps/circular_dependencies.json that referenced the legacy i18nStringTracker module (removed in related work), keeping the circular dependency checker output accurate and reducing noise in CI warnings.

Changes:

  • Delete four stale circular-dependency entries involving src/util/i18nStringTracker.js.
  • Keep the circular dependency allowlist aligned with the current apps/src module graph.

@artem-vavilov artem-vavilov merged commit e19b644 into staging Jun 24, 2026
9 checks passed
@artem-vavilov artem-vavilov deleted the circular-dependencies-fix branch June 24, 2026 15:13
Nokondi pushed a commit that referenced this pull request Jun 24, 2026
@artem-vavilov @Nokondi
fix(circular-dependencies): remove resolved i18nStringTracker cycles (#…
b852a7e 
…73445)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@carl-codeorg carl-codeorg carl-codeorg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@artem-vavilov @carl-codeorg