Skip to content

Update header font sizes for free-response questions#72684

Merged
Hamms merged 3 commits into
stagingfrom
alice/update-header-style
May 15, 2026
Merged

Update header font sizes for free-response questions#72684
Hamms merged 3 commits into
stagingfrom
alice/update-header-style

Conversation

@fisher-alice

@fisher-alice fisher-alice commented May 15, 2026

Copy link
Copy Markdown
Contributor

This PR updates the font sizes for h1, h2, and h3 for free response levels following up #72667. Free response questions are included in the instructions panel in legacy labs, so we remove overwriting the header font sizes for .free-response. However the default p font size remains 16px as preferred by the T&L team.

This essentially reverts #72667 other than the styling for li.

Before update

37px

After update

18px

Links

  • Jira:

Testing story

Deployment notes

Privacy and security

@fisher-alice fisher-alice requested a review from moshebaricdo May 15, 2026 18:36
@fisher-alice fisher-alice changed the title Update header font sizes Update header font sizes for free-response questions May 15, 2026
@fisher-alice fisher-alice marked this pull request as ready for review May 15, 2026 18:49
@fisher-alice fisher-alice requested a review from Hamms May 15, 2026 18:50

@moshebaricdo moshebaricdo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty!

@Hamms Hamms left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for jumping on this!

@Hamms

Hamms commented May 15, 2026

Copy link
Copy Markdown
Contributor

Merging despite UI test failures; they look unrelated, and the test pipeline is blocked waiting on this fix anyway

@Hamms Hamms merged commit 8c6ee02 into staging May 15, 2026
7 of 8 checks passed
@Hamms Hamms deleted the alice/update-header-style branch May 15, 2026 19:19
Hamms added a commit that referenced this pull request May 15, 2026
* Rename copilot-instructions.md to copilot.instructions.md

* refactor(i18n): improve locale handling (#72641)

* add indices (#72648)

* Update schema cache dump after schema changes.

* Restore Original Drone Cache (#72649)

* Restore Original Drone Cache

Follow-up to #68860,
which targeted a temporary cache file to minimize disruption.

* rebuild original cache image

* Revert "rebuild original cache image"

This reverts commit f323260.

* Font size updates for external file types (#72660)

* update stylesheet for external files

* add label and li

* script

* video tylsheet

* Revert "video tylsheet"

This reverts commit cbf9bf1.

* update external files

* update script

* delete script

* Video levels CSS change/markdown edit (#72662)

* Font size updates for free-response levels (#72667)

* Update application.scss

* remove updates from .text-match and .peer-review

* Update application.scss

* consolidate

* Update application.scss

* Adds a fairly complete Tanstack-query API using ky as a configurable transport. (#72026)

* Adds a fairly complete Tanstack-query API using ky as a configurable transport.

* Adds transports documentation.

* Commits yarn.lock.

* Type fixes for music lab

* Updates music-lab tests to wrap the mock transport.

* Update frontend/packages/core/src/api/QueryClientProvider.tsx

Co-authored-by: Stephen Liang <stephenliang@users.noreply.github.com>

* Update frontend/packages/core/src/api/bootstrapApiClient.ts

Co-authored-by: Stephen Liang <stephenliang@users.noreply.github.com>

* Apply suggestion from @wilkie

* Refactors the level properties request params and API calls.

* Determines level properties URL with type discrimination.

* Places @tanstack/react-query into catalog.

* Fixes type issue in design-system-storybook

* Fixes format issue.

---------

Co-authored-by: Stephen Liang <538214+stephenliang@users.noreply.github.com>
Co-authored-by: Stephen Liang <stephenliang@users.noreply.github.com>

* levelbuilder content changes (-robo-commit) (#72682)

Co-authored-by: Continuous Integration <dev@code.org>
Co-authored-by: Stephen Liang <538214+stephenliang@users.noreply.github.com>

* Update header font sizes for free-response questions (#72684)

* update header sizes

* revert header size changes for video and external

* remove header styling for free-response

* manually resolve merge conflict with levelbuilder

---------

Co-authored-by: Hannah Bergam <hannahbergam@gmail.com>
Co-authored-by: Artem Vavilov <artem.vavilov.7@gmail.com>
Co-authored-by: Code.org Deploy Systems <dev@code.org>
Co-authored-by: Mark Barnes <mark.barnes@code.org>
Co-authored-by: fisher-alice <107423305+fisher-alice@users.noreply.github.com>
Co-authored-by: Eric Aderhold <eric.aderhold@code.org>
Co-authored-by: alex-m-brown <alex.brown@code.org>
Co-authored-by: wilkie <david.wilkinson@code.org>
Co-authored-by: Stephen Liang <538214+stephenliang@users.noreply.github.com>
Co-authored-by: Stephen Liang <stephenliang@users.noreply.github.com>
Co-authored-by: Alice Fisher <alice.fisher@code.org>
@fisher-alice

Copy link
Copy Markdown
Contributor Author

Just noting that for contained free-response levels rendered within instructions panel such as https://studio.code.org/courses/allthethingscourse/units/1/lessons/18/levels/15 (used in an eyes test), header tags are styled by the h1 rule in common.scss.

h1 {
@include main-font-bold;
font-size: 140%;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants