Update header font sizes for free-response questions#72684
Merged
Conversation
Hamms
approved these changes
May 15, 2026
Hamms
left a comment
Contributor
There was a problem hiding this comment.
Thanks for jumping on this!
Contributor
|
Merging despite UI test failures; they look unrelated, and the test pipeline is blocked waiting on this fix anyway |
Hamms
added a commit
that referenced
this pull request
May 15, 2026
* Rename copilot-instructions.md to copilot.instructions.md * refactor(i18n): improve locale handling (#72641) * add indices (#72648) * Update schema cache dump after schema changes. * Restore Original Drone Cache (#72649) * Restore Original Drone Cache Follow-up to #68860, which targeted a temporary cache file to minimize disruption. * rebuild original cache image * Revert "rebuild original cache image" This reverts commit f323260. * Font size updates for external file types (#72660) * update stylesheet for external files * add label and li * script * video tylsheet * Revert "video tylsheet" This reverts commit cbf9bf1. * update external files * update script * delete script * Video levels CSS change/markdown edit (#72662) * Font size updates for free-response levels (#72667) * Update application.scss * remove updates from .text-match and .peer-review * Update application.scss * consolidate * Update application.scss * Adds a fairly complete Tanstack-query API using ky as a configurable transport. (#72026) * Adds a fairly complete Tanstack-query API using ky as a configurable transport. * Adds transports documentation. * Commits yarn.lock. * Type fixes for music lab * Updates music-lab tests to wrap the mock transport. * Update frontend/packages/core/src/api/QueryClientProvider.tsx Co-authored-by: Stephen Liang <stephenliang@users.noreply.github.com> * Update frontend/packages/core/src/api/bootstrapApiClient.ts Co-authored-by: Stephen Liang <stephenliang@users.noreply.github.com> * Apply suggestion from @wilkie * Refactors the level properties request params and API calls. * Determines level properties URL with type discrimination. * Places @tanstack/react-query into catalog. * Fixes type issue in design-system-storybook * Fixes format issue. --------- Co-authored-by: Stephen Liang <538214+stephenliang@users.noreply.github.com> Co-authored-by: Stephen Liang <stephenliang@users.noreply.github.com> * levelbuilder content changes (-robo-commit) (#72682) Co-authored-by: Continuous Integration <dev@code.org> Co-authored-by: Stephen Liang <538214+stephenliang@users.noreply.github.com> * Update header font sizes for free-response questions (#72684) * update header sizes * revert header size changes for video and external * remove header styling for free-response * manually resolve merge conflict with levelbuilder --------- Co-authored-by: Hannah Bergam <hannahbergam@gmail.com> Co-authored-by: Artem Vavilov <artem.vavilov.7@gmail.com> Co-authored-by: Code.org Deploy Systems <dev@code.org> Co-authored-by: Mark Barnes <mark.barnes@code.org> Co-authored-by: fisher-alice <107423305+fisher-alice@users.noreply.github.com> Co-authored-by: Eric Aderhold <eric.aderhold@code.org> Co-authored-by: alex-m-brown <alex.brown@code.org> Co-authored-by: wilkie <david.wilkinson@code.org> Co-authored-by: Stephen Liang <538214+stephenliang@users.noreply.github.com> Co-authored-by: Stephen Liang <stephenliang@users.noreply.github.com> Co-authored-by: Alice Fisher <alice.fisher@code.org>
Contributor
Author
|
Just noting that for contained free-response levels rendered within instructions panel such as https://studio.code.org/courses/allthethingscourse/units/1/lessons/18/levels/15 (used in an eyes test), header tags are styled by the code-dot-org/apps/style/common.scss Lines 59 to 61 in 66dc244 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the font sizes for
h1,h2, andh3for free response levels following up #72667. Free response questions are included in the instructions panel in legacy labs, so we remove overwriting the header font sizes for.free-response. However the defaultpfont size remains16pxas preferred by the T&L team.This essentially reverts #72667 other than the styling for
li.Before update
After update
Links
Testing story
Deployment notes
Privacy and security