Skip to content

Font size updates for external file types#72660

Merged
fisher-alice merged 8 commits into
stagingfrom
alice/font-size-update
May 13, 2026
Merged

Font size updates for external file types#72660
fisher-alice merged 8 commits into
stagingfrom
alice/font-size-update

Conversation

@fisher-alice

@fisher-alice fisher-alice commented May 13, 2026

Copy link
Copy Markdown
Contributor

This PR updates the font size styling for .external files (text level types for levelbuilders) so that the default body text size is 16px and the other font sizes are updated proportionately. 16px actually matches what is used for .free-response files. PL writers were using <h4> or #### to increase the font size of body text so we ran a script to update .external files to remove #### or replace <h4> with <p>. This was quite disruptive for a user using a SR, and it is tedious for curriculum writers to use this workaround.

Here is the script used to update files.

Links

Testing story

After updating the stylesheet locally, I ran the script to update .external files, seeded, then checked several .external levels and confirmed text looked as expected.

Before update

Note that the body text below uses <h4> tags to increase font.

before-levelbuilder

After update

Body text uses <p> tags.

after-update-external

Deployment notes

Privacy and security

overflow: hidden;

p, label, li {
font-size: 16px;

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Body text updated - note that font size now matches .text-match, .free-response, .peer-review above in line 2706.

@fisher-alice fisher-alice marked this pull request as ready for review May 13, 2026 17:25

@hannahbergam hannahbergam left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fisher-alice fisher-alice requested a review from molly-moen May 13, 2026 17:50
@fisher-alice fisher-alice merged commit 57031fd into staging May 13, 2026
8 checks passed
@fisher-alice fisher-alice deleted the alice/font-size-update branch May 13, 2026 17:53
Hamms added a commit that referenced this pull request May 15, 2026
* Rename copilot-instructions.md to copilot.instructions.md

* refactor(i18n): improve locale handling (#72641)

* add indices (#72648)

* Update schema cache dump after schema changes.

* Restore Original Drone Cache (#72649)

* Restore Original Drone Cache

Follow-up to #68860,
which targeted a temporary cache file to minimize disruption.

* rebuild original cache image

* Revert "rebuild original cache image"

This reverts commit f323260.

* Font size updates for external file types (#72660)

* update stylesheet for external files

* add label and li

* script

* video tylsheet

* Revert "video tylsheet"

This reverts commit cbf9bf1.

* update external files

* update script

* delete script

* Video levels CSS change/markdown edit (#72662)

* Font size updates for free-response levels (#72667)

* Update application.scss

* remove updates from .text-match and .peer-review

* Update application.scss

* consolidate

* Update application.scss

* Adds a fairly complete Tanstack-query API using ky as a configurable transport. (#72026)

* Adds a fairly complete Tanstack-query API using ky as a configurable transport.

* Adds transports documentation.

* Commits yarn.lock.

* Type fixes for music lab

* Updates music-lab tests to wrap the mock transport.

* Update frontend/packages/core/src/api/QueryClientProvider.tsx

Co-authored-by: Stephen Liang <stephenliang@users.noreply.github.com>

* Update frontend/packages/core/src/api/bootstrapApiClient.ts

Co-authored-by: Stephen Liang <stephenliang@users.noreply.github.com>

* Apply suggestion from @wilkie

* Refactors the level properties request params and API calls.

* Determines level properties URL with type discrimination.

* Places @tanstack/react-query into catalog.

* Fixes type issue in design-system-storybook

* Fixes format issue.

---------

Co-authored-by: Stephen Liang <538214+stephenliang@users.noreply.github.com>
Co-authored-by: Stephen Liang <stephenliang@users.noreply.github.com>

* levelbuilder content changes (-robo-commit) (#72682)

Co-authored-by: Continuous Integration <dev@code.org>
Co-authored-by: Stephen Liang <538214+stephenliang@users.noreply.github.com>

* Update header font sizes for free-response questions (#72684)

* update header sizes

* revert header size changes for video and external

* remove header styling for free-response

* manually resolve merge conflict with levelbuilder

---------

Co-authored-by: Hannah Bergam <hannahbergam@gmail.com>
Co-authored-by: Artem Vavilov <artem.vavilov.7@gmail.com>
Co-authored-by: Code.org Deploy Systems <dev@code.org>
Co-authored-by: Mark Barnes <mark.barnes@code.org>
Co-authored-by: fisher-alice <107423305+fisher-alice@users.noreply.github.com>
Co-authored-by: Eric Aderhold <eric.aderhold@code.org>
Co-authored-by: alex-m-brown <alex.brown@code.org>
Co-authored-by: wilkie <david.wilkinson@code.org>
Co-authored-by: Stephen Liang <538214+stephenliang@users.noreply.github.com>
Co-authored-by: Stephen Liang <stephenliang@users.noreply.github.com>
Co-authored-by: Alice Fisher <alice.fisher@code.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants