Use Latest Stable Chromedriver in CI#64444
Merged
Merged
Conversation
Hamms
commented
Mar 11, 2025
|
|
||
| ######################################################### | ||
| FROM ubuntu:20.04 as base | ||
| FROM ubuntu:20.04 AS base |
Contributor
Author
There was a problem hiding this comment.
I was getting warnings on build:
3 warnings found (use --debug to expand):
- FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 11)
- FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 53)
- FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 70)
Seemed easy enough to fix while I was in the area
Hamms
commented
Mar 14, 2025
| # see: docker/ci/Dockerfile | ||
| # TODO: switch to codedotorg/cdo-ci | ||
| image: codedotorg/code-dot-org:1.14 | ||
| image: codedotorg/code-dot-org:chrome-for-testing |
Contributor
Author
There was a problem hiding this comment.
upon approval, I'll retag this image as code-dot-org:1.15 and update and sign .drone.yml
stephenliang
approved these changes
Mar 14, 2025
sureshc
approved these changes
Mar 14, 2025
Hamms
added a commit
that referenced
this pull request
May 6, 2026
* Sync Chrome and chromedriver in CI Specifically, rather than installing the latest stable version of chromedriver we instead target a version that exactly matches the installed version of the chrome browser, which is likely to be slightly behind. Ideally we would be installing the latest stable version of the chrome browser, too, rather than relying on whatever's in the `.deb`, but as noted in #64444 that is a much more difficult proposition. See thread [here](https://codedotorg.slack.com/archives/C0T0PNTM3/p1778091262918919) for more context * target new image and re-sign drone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Google has deprecated the
http://chromedriver.storage.googleapis.cominstallation endpoint in favor of the newhttps://googlechromelabs.github.io/chrome-for-testing/approach. As such, although our CI image is using a relatively recent version of chrome, its version of chromedriver is quite out of date:In preparation for some ongoing work to run Selenium within Drone, we need Chrome and Chromedriver to be at similar versions. Which they now are:
Note that we are still installing Chrome via
https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb, which will not always be exactly up to date with thechrome-for-testingdistribution. It is significantly more complicated to install manually than chromedriver is, unfortunately, so I left it as-is for now. The two dependencies should be kept significantly more in sync than previously, even if they won't be perfect.Links
Testing story
Relying entirely on Drone CI to validate this Drone-CI-only change
Deployment strategy
BEFORE MERGING
Tag image with
1.15PR Checklist: