use local selenium directly in drone#64432
Closed
Hamms wants to merge 51 commits into
Closed
Conversation
This reverts commit 014ac15.
8 tasks
…al-selenium-in-drone
…labs rather than local
…e do locally doesn't result in fewer total attempts against sauce
This reverts commit 0e30b91.
…lijah/local-selenium-in-drone
…out to see if that helps
One of the UI test steps we use for a few different tests (most significantly, [`teacher_homepage.feature`](https://github.com/code-dot-org/code-dot-org/blob/staging/dashboard/test/ui/features/teacher_tools/teacher_homepage.feature)) has a subtle bug which is causing some flakiness. Specifically, it is attempting to use the `wait_until` helper to grab a `href` value from an asyncronously-populated UI element, but the check its using will always return true, so we will always immediately proceed with the rest of the test. This does not, however, result in a consistent failure; we have other scenarios within that UI test which will load the relevant data and which [are already using a bug-free step](https://github.com/code-dot-org/code-dot-org/blob/0ee07a79125036a45de281affd4455c985387b88/dashboard/test/ui/features/step_definitions/section_management_steps.rb#L273) to check their own correctness. If any of those scenarios run before the scenario using this step, this step will work fine. Otherwise, [it will fail](https://cucumber-logs.s3.amazonaws.com/circle/28036/Chrome_teacher_tools_teacher_homepage_output.html?versionId=squ0Qr6sp1xIrWEtB99GABiImDA3YXHD) The simple fix is to use the same check for both steps.
Contributor
Author
|
Closing in favor of #65064 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rather than trying to host a grid locally
Links
Depends on:
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: