Skip to content

use local selenium directly in drone#64432

Closed
Hamms wants to merge 51 commits into
stagingfrom
elijah/local-selenium-in-drone
Closed

use local selenium directly in drone#64432
Hamms wants to merge 51 commits into
stagingfrom
elijah/local-selenium-in-drone

Conversation

@Hamms

@Hamms Hamms commented Mar 10, 2025

Copy link
Copy Markdown
Contributor

rather than trying to host a grid locally

Links

Depends on:

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@Hamms Hamms mentioned this pull request Mar 14, 2025
8 tasks
Hamms added 9 commits April 1, 2025 13:51
One of the UI test steps we use for a few different tests (most
significantly,
[`teacher_homepage.feature`](https://github.com/code-dot-org/code-dot-org/blob/staging/dashboard/test/ui/features/teacher_tools/teacher_homepage.feature))
has a subtle bug which is causing some flakiness.

Specifically, it is attempting to use the `wait_until` helper to grab a
`href` value from an asyncronously-populated UI element, but the check
its using will always return true, so we will always immediately proceed
with the rest of the test. This does not, however, result in a
consistent failure; we have other scenarios within that UI test which
will load the relevant data and which [are already using a bug-free
step](https://github.com/code-dot-org/code-dot-org/blob/0ee07a79125036a45de281affd4455c985387b88/dashboard/test/ui/features/step_definitions/section_management_steps.rb#L273)
to check their own correctness. If any of those scenarios run before the
scenario using this step, this step will work fine. Otherwise, [it will
fail](https://cucumber-logs.s3.amazonaws.com/circle/28036/Chrome_teacher_tools_teacher_homepage_output.html?versionId=squ0Qr6sp1xIrWEtB99GABiImDA3YXHD)

The simple fix is to use the same check for both steps.
@Hamms

Hamms commented Apr 15, 2025

Copy link
Copy Markdown
Contributor Author

Closing in favor of #65064

@Hamms Hamms closed this Apr 15, 2025
@Hamms Hamms deleted the elijah/local-selenium-in-drone branch April 15, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant