Skip to content

Update page titles for levels, script overview, teacher dashboard#44014

Merged
maureensturgeon merged 2 commits into
stagingfrom
maureen/LP-2066-page-titles
Dec 15, 2021
Merged

Update page titles for levels, script overview, teacher dashboard#44014
maureensturgeon merged 2 commits into
stagingfrom
maureen/LP-2066-page-titles

Conversation

@maureensturgeon

@maureensturgeon maureensturgeon commented Dec 10, 2021

Copy link
Copy Markdown
Contributor

Updates page titles so that they're more useful.

Examples of changes:
Code.org - Dance Party (2019) #10 -> Dance Party (2019) #10 - Code.org
Code.org - CSD Unit 3 - Interactive Animations and Games ('20-'21): Drawing in Game Lab #6 -> Drawing in Game Lab #6 | CSD Unit 3 - Interactive Animations and Games ('20-'21) - Code.org
Code.org -> Course D (2020) - Code.org
Code.org -> Teacher Dashboard - Code.org

Before:
Screen Shot 2021-12-10 at 1 47 34 PM

After:
Screen Shot 2021-12-10 at 1 45 56 PM

Links

Testing story

Tested locally

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@maureensturgeon maureensturgeon marked this pull request as ready for review December 13, 2021 21:07
@maureensturgeon maureensturgeon requested a review from a team as a code owner December 13, 2021 21:07
@maureensturgeon maureensturgeon requested a review from a team December 13, 2021 21:07

@jamescodeorg jamescodeorg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a Slack thread or something that we can add as reference for what the "rules" are for the page titles?

@maureensturgeon

Copy link
Copy Markdown
Contributor Author

Is there a Slack thread or something that we can add as reference for what the "rules" are for the page titles?

We do not have specific rules for our page titles right now. I took a look at how some other major websites handle this and decided that what would be the most useful for us and seems to fit with the general pattern is to have the title from most specific to least specific, for example for a level: <Level name> <script name> - Code.org

@maureensturgeon maureensturgeon changed the base branch from staging-next to staging December 15, 2021 00:30
@maureensturgeon maureensturgeon force-pushed the maureen/LP-2066-page-titles branch from 254fd51 to f5e077c Compare December 15, 2021 01:45
@maureensturgeon maureensturgeon force-pushed the maureen/LP-2066-page-titles branch from 28578af to fb75273 Compare December 15, 2021 20:29
@maureensturgeon maureensturgeon mentioned this pull request Dec 15, 2021
8 tasks
@maureensturgeon maureensturgeon merged commit 30da1c2 into staging Dec 15, 2021
@maureensturgeon maureensturgeon deleted the maureen/LP-2066-page-titles branch December 15, 2021 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants