Skip to content

Additional page titles#44079

Merged
maureensturgeon merged 5 commits into
stagingfrom
maureen/lp-page-titles-2
Jan 5, 2022
Merged

Additional page titles#44079
maureensturgeon merged 5 commits into
stagingfrom
maureen/lp-page-titles-2

Conversation

@maureensturgeon

@maureensturgeon maureensturgeon commented Dec 15, 2021

Copy link
Copy Markdown
Contributor
  • Added title for All feedbacks page, title="Teacher Feedback"
  • Updated title for lesson plans on code studio, added lesson number after lesson name
  • Updated title for standalone projects, appended "- Code.org" to the end for consistency

Testing story

Tested locally

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@maureensturgeon maureensturgeon changed the title Maureen/lp page titles 2 Additional page titles Dec 15, 2021
@maureensturgeon maureensturgeon marked this pull request as ready for review December 15, 2021 20:39
@maureensturgeon maureensturgeon requested a review from a team as a code owner December 15, 2021 20:39
Base automatically changed from maureen/LP-2066-page-titles to staging December 15, 2021 23:08
@maureensturgeon maureensturgeon requested a review from a team December 16, 2021 00:24
Comment thread dashboard/app/helpers/levels_helper.rb Outdated
script
end
elsif @level.try(:is_project_level) && data_t("game.name", @game.name)
# This is updated in project.js with the name of the project

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you paste a link to the code you're referencing?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/code-dot-org/code-dot-org/blob/staging/apps/src/code-studio/initApp/project.js#L661-L665. The reason I didn't put a link in the comments is because the line number is likely to change, was there something more specific you wanted in the comment?

@maureensturgeon maureensturgeon merged commit 4911c1d into staging Jan 5, 2022
@maureensturgeon maureensturgeon deleted the maureen/lp-page-titles-2 branch January 5, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants