Skip to content

Test Github.Sync.installation/1 event #1379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
begedin merged 5 commits into from
Mar 16, 2018
Merged

Test Github.Sync.installation/1 event #1379

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
315ae78
Test to check that an installation event runs smoothly
zacck Feb 19, 2018
7d651fd
Test for validation errors on syncing installation
zacck Feb 19, 2018
0ccebdb
Add tests for multiple unprocessed installations
zacck Feb 19, 2018
e960094
Test for api error during sync
zacck Feb 23, 2018
2e80a18
use comment rather than doc
zacck Mar 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 42 additions & 1 deletion test/lib/code_corps/github/sync/sync_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,49 @@ defmodule CodeCorps.GitHub.SyncTest do

alias Ecto.Changeset

describe "installation_repositories_event/1 added" do

# Some clauses defined seem difficult or impossible to reach so their tests were omitted
# - {:error, :validation_error_on_syncing_installation, Changeset.t()}
# - {:error, :validation_error_on_marking_installation_processed, Changeset.t()}
# - {:error, :unexpected_transaction_outcome, any}
# However, if these clauses can be caused by some updates upstream we should cover them with tests

describe "installation_event" do

@payload load_event_fixture("installation_created")

test "syncs_correctly_with valid data" do
%{"installation" => %{"id" => installation_id}} = @payload

assert Repo.aggregate(GithubAppInstallation, :count, :id) == 0

{:ok, installation} = Sync.installation_event(@payload)


assert Repo.aggregate(GithubAppInstallation, :count, :id) == 1
assert installation.github_id == installation_id
end

test "fails if multiple installations are unprocessed" do
user = insert(:user, github_id: @payload["sender"]["id"])
project = insert(:project)
attrs = %{project: project, user: user, sender_github_id: user.id, github_id: nil}
insert(:github_app_installation, attrs)
insert(:github_app_installation, attrs)

{:error, :multiple_unprocessed_installations_found} = Sync.installation_event(@payload)
end

test "fails on syncing api error" do
with_mock_api(CodeCorps.GitHub.FailureAPI) do
assert {:error, :github_api_error_on_syncing_repos, _error} = Sync.installation_event(@payload)
end
end
end



describe "installation_repositories_event/1 added" do
@payload load_event_fixture("installation_repositories_added")

test "syncs_correctly when adding" do
Expand Down