Test Github.Sync.installation/1 event #1379
Merged
Merged
Conversation
8d2ebea to
224c80f
Compare
Member
Author
|
Some clauses defined seem difficult or impossible to reach so their tests were omitted
|
remoe erronous field
add tests for syncing existing repositories remove erronous test
24e9506 to
e960094
Compare
begedin
requested changes
Mar 13, 2018
Contributor
begedin
left a comment
There was a problem hiding this comment.
Just a small change here and good to go 👍
| - {:error, :validation_error_on_marking_installation_processed, Changeset.t()} | ||
| - {:error, :unexpected_transaction_outcome, any} | ||
| However, if these clauses can be caused by some updates upstream we should cover them with tests | ||
| """ |
Contributor
There was a problem hiding this comment.
@doc is used generally for public function documentation only (def). This should just be a simple comment:
# Some clauses defined seem difficult or impossible to reach so their tests were omitted
# - {:error, :validation_error_on_syncing_installation, Changeset.t()}
# - {:error, :validation_error_on_marking_installation_processed, Changeset.t()}
# - {:error, :unexpected_transaction_outcome, any}
# However, if these clauses can be caused by some updates upstream we should cover them with testsAlso, "omitted" is spelled with one m
begedin
approved these changes
Mar 16, 2018
Member
Author
|
🤘 |
Contributor
|
Merged 👍 Thank you for your time and work @zacck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Added a test block for Github.Sync.installation event
Make sure any changes to code include changes to documentation.
References
Fixes #1373
Progress on: #