Skip to content

chore(ci): Log check run ID to detect duplicates #9793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 1 commit into from
Apr 10, 2023
Merged

chore(ci): Log check run ID to detect duplicates #9793

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
chore(ci): Log check run ID to detect duplicates
  • Loading branch information
@erezrokah
erezrokah committed Apr 10, 2023
commit d28fc22b57ebc7bad8c117e9b23ecc871da3054c
2 changes: 1 addition & 1 deletion .github/workflows/wait_for_required_workflows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ jobs:
status: 'completed',
per_page: 100
})
const runs = checkRuns.map(({ name, conclusion }) => ({ name, conclusion }))
const runs = checkRuns.map(({ id, name, conclusion }) => ({ id, name, conclusion }))
Copy link
Copy Markdown
Member Author

@erezrokah erezrokah Apr 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why the diff shows the first id with the space after the comma, and the second id with the space before 🤷

console.log(`Got the following check runs: ${JSON.stringify(runs)}`)
const matchingRuns = runs.filter(({ name }) => actions.includes(name))
const failedRuns = matchingRuns.filter(({ conclusion }) => conclusion !== 'success')
Expand Down