chore(ci): Log check run ID to detect duplicates#9793
Merged
Conversation
hermanschaaf
approved these changes
Apr 10, 2023
erezrokah
commented
Apr 10, 2023
| per_page: 100 | ||
| }) | ||
| const runs = checkRuns.map(({ name, conclusion }) => ({ name, conclusion })) | ||
| const runs = checkRuns.map(({ id, name, conclusion }) => ({ id, name, conclusion })) |
Member
Author
There was a problem hiding this comment.
I wonder why the diff shows the first id with the space after the comma, and the second id with the space before 🤷
This was referenced Apr 10, 2023
kodiakhq Bot
pushed a commit
that referenced
this pull request
Apr 10, 2023
Follow-up from #9793. Closes #9797 Additionally, had to fix `name` entry for the following destination workflows: * ClIckHouse * Meilisearch * MSSQL As we [scan](https://github.com/cloudquery/cloudquery/blob/main/.github/workflows/wait_for_required_workflows.yml#L37) for a specific pattern in `wait-for-required-workflows`, namely, `name: "${action}"`.
kodiakhq Bot
pushed a commit
that referenced
this pull request
Apr 11, 2023
#### Summary Fixes #9797. Follow up to #9793 and replaces #9813. #9797 (comment) Confirms the ID is duplicated and we can filter using it <!--
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to #9736 (comment). We've seen cases were apparently the GitHub JS SDK returns duplicate check runs, so adding a log for the ID to see what's up.