chore: Fix readme table links#8764
Merged
Merged
Conversation
hermanschaaf
approved these changes
Mar 7, 2023
Contributor
hermanschaaf
left a comment
There was a problem hiding this comment.
LGTM, however the GCP workflow failed @erezrokah
Member
Author
|
Thanks @hermanschaaf, GCP failure will be fixed in #8767 (we don't run the code that syncs the services on each PR). Probably we should skip the services generation on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to #8732 to fix the links in the README.md files (we could also bring the tables back altogether, but I'm hoping this is only temporary that we have the README under both the plugin and the Website)