Skip to content

chore: Bring back plugins readme files#8732

Merged
kodiakhq[bot] merged 1 commit into
cloudquery:mainfrom
erezrokah:chore/bring_back_plugins_readmes
Mar 6, 2023
Merged

chore: Bring back plugins readme files#8732
kodiakhq[bot] merged 1 commit into
cloudquery:mainfrom
erezrokah:chore/bring_back_plugins_readmes

Conversation

@erezrokah
Copy link
Copy Markdown
Member

Summary

Apparently some users are parsing these files to get the list of tables

@erezrokah erezrokah requested a review from a team March 6, 2023 16:47
@erezrokah erezrokah added the automerge Automatically merge once required checks pass label Mar 6, 2023
@hermanschaaf
Copy link
Copy Markdown
Contributor

To reduce duplication, maybe we can copy the files to the website directory as part of the prebuild step?

@erezrokah
Copy link
Copy Markdown
Member Author

To reduce duplication, maybe we can copy the files to the website directory as part of the prebuild step?

I'm not sure I follow this. Do you mean copy the README.md under plugins/source/alicloud/docs/tables/README.md to the Website in the prebuild step? If so we'll need to update our Vercel git ignore command to account for that (check if that file changes). Not sure what's better actually

@kodiakhq kodiakhq Bot merged commit 2f9220e into cloudquery:main Mar 6, 2023
@erezrokah erezrokah deleted the chore/bring_back_plugins_readmes branch March 7, 2023 13:07
kodiakhq Bot pushed a commit that referenced this pull request Mar 7, 2023

#### Summary

Follow up to #8732 to fix the links in the README.md files (we could also bring the tables back altogether, but I'm hoping this is only temporary that we have the README under both the plugin and the Website)

<!--
daniel-garcia pushed a commit to infobloxopen/ibcq-source-k8s that referenced this pull request Feb 24, 2026

#### Summary

Follow up to cloudquery/cloudquery#8732 to fix the links in the README.md files (we could also bring the tables back altogether, but I'm hoping this is only temporary that we have the README under both the plugin and the Website)

<!--
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Automatically merge once required checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants