feat(cli): Update CLI to support source v1 protocol #6986
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| package cmd | ||
|
|
||
| import ( | ||
| "errors" | ||
|
|
||
| "google.golang.org/grpc/codes" | ||
| "google.golang.org/grpc/status" | ||
| ) | ||
|
|
||
| // isUnimplemented returns true if an error indicates that the underlying grpc call | ||
| // was unimplemented on the server side. | ||
| func isUnimplemented(err error) bool { | ||
| if err == nil { | ||
| return false | ||
| } | ||
| st, ok := status.FromError(err) | ||
| if ok && st.Code() == codes.Unimplemented { | ||
| return true | ||
| } | ||
| err = errors.Unwrap(err) | ||
| return isUnimplemented(err) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| package cmd | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
| "time" | ||
|
|
||
| source "github.com/cloudquery/plugin-sdk/clients/source/v0" | ||
| "github.com/cloudquery/plugin-sdk/specs" | ||
| "github.com/rs/zerolog/log" | ||
| ) | ||
|
|
||
| func migrateConnectionV0(ctx context.Context, cqDir string, sourceSpec specs.Source, destinationsSpecs []specs.Destination) error { | ||
|
Member
There was a problem hiding this comment. Maybe we should put these in separate packages? instead of postfixing the methods something like
Contributor
Author
There was a problem hiding this comment. I would avoid this for now I think it will cause all things like cyclical imports but also on the CLI I don't think it should be different packages as we don't import it so it should only be on the SDK. |
||
| destinationNames := make([]string, len(destinationsSpecs)) | ||
| for i := range destinationsSpecs { | ||
| destinationNames[i] = destinationsSpecs[i].Name | ||
| } | ||
| migrateTime := time.Now().UTC() | ||
|
|
||
| log.Info().Str("source", sourceSpec.Name).Strs("destinations", destinationNames).Time("migrate_time", migrateTime).Msg("Start migration") | ||
| defer log.Info().Str("source", sourceSpec.Name).Strs("destinations", destinationNames).Time("migrate_time", migrateTime).Msg("End migration") | ||
|
|
||
| sourceClient, err := source.NewClient(ctx, sourceSpec.Registry, sourceSpec.Path, sourceSpec.Version, | ||
| source.WithLogger(log.Logger), | ||
| source.WithDirectory(cqDir), | ||
| ) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to get source plugin client for %s: %w", sourceSpec.Name, err) | ||
| } | ||
| defer func() { | ||
| if err := sourceClient.Terminate(); err != nil { | ||
| log.Error().Err(err).Msg("Failed to terminate source client") | ||
| fmt.Println("failed to terminate source client:", err) | ||
| } | ||
| }() | ||
|
|
||
| destClients, err := newDestinationClientsV0(ctx, sourceSpec, destinationsSpecs, cqDir) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| defer destClients.Close() | ||
|
|
||
| selectedTables, tablesForSpecSupported, err := getTablesForSpec(ctx, sourceClient, sourceSpec) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to get tables for source %s: %w", sourceSpec.Name, err) | ||
| } | ||
| tableCount := len(selectedTables.FlattenTables()) | ||
|
|
||
| // Print a count of the tables that will be migrated. | ||
| if tablesForSpecSupported { | ||
| word := "tables" | ||
| if tableCount == 1 { | ||
| word = "table" | ||
| } | ||
| fmt.Printf("Source %s will migrate %d %s.\n", sourceSpec.Name, tableCount, word) | ||
| } | ||
|
|
||
| fmt.Println("Starting migration for:", sourceSpec.Name, "->", sourceSpec.Destinations) | ||
| log.Info().Str("source", sourceSpec.Name).Strs("destinations", sourceSpec.Destinations).Msg("Starting migration") | ||
|
|
||
| for i, destinationSpec := range destinationsSpecs { | ||
| if err := destClients[i].Migrate(ctx, selectedTables); err != nil { | ||
| return fmt.Errorf("failed to migrate source %s on destination %s : %w", sourceSpec.Name, destinationSpec.Name, err) | ||
| } | ||
| } | ||
| tt := time.Since(migrateTime) | ||
| fmt.Printf("Migration completed successfully.\n") | ||
| log.Info().Str("source", sourceSpec.Name). | ||
| Strs("destinations", sourceSpec.Destinations). | ||
| Int("num_tables", tableCount). | ||
| Float64("time_took", tt.Seconds()). | ||
| Msg("Migration completed successfully") | ||
|
|
||
| return nil | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| package cmd | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
| "time" | ||
|
|
||
| source "github.com/cloudquery/plugin-sdk/clients/source/v1" | ||
| "github.com/cloudquery/plugin-sdk/specs" | ||
| "github.com/rs/zerolog/log" | ||
| ) | ||
|
|
||
| func migrateConnectionV1(ctx context.Context, cqDir string, sourceSpec specs.Source, destinationsSpecs []specs.Destination) error { | ||
| destinationNames := make([]string, len(destinationsSpecs)) | ||
| for i := range destinationsSpecs { | ||
| destinationNames[i] = destinationsSpecs[i].Name | ||
| } | ||
| migrateTime := time.Now().UTC() | ||
|
|
||
| log.Info().Str("source", sourceSpec.Name).Strs("destinations", destinationNames).Time("migrate_time", migrateTime).Msg("Start migration") | ||
| defer log.Info().Str("source", sourceSpec.Name).Strs("destinations", destinationNames).Time("migrate_time", migrateTime).Msg("End migration") | ||
|
|
||
| sourceClient, err := source.NewClient(ctx, sourceSpec.Registry, sourceSpec.Path, sourceSpec.Version, | ||
| source.WithLogger(log.Logger), | ||
| source.WithDirectory(cqDir), | ||
| ) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to get source plugin client for %s: %w", sourceSpec.Name, err) | ||
| } | ||
| defer func() { | ||
| if err := sourceClient.Terminate(); err != nil { | ||
| log.Error().Err(err).Msg("Failed to terminate source client") | ||
| fmt.Println("failed to terminate source client:", err) | ||
| } | ||
| }() | ||
|
|
||
| destClients, err := newDestinationClientsV0(ctx, sourceSpec, destinationsSpecs, cqDir) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| defer destClients.Close() | ||
|
|
||
| if err := sourceClient.Init(ctx, sourceSpec); err != nil { | ||
| return fmt.Errorf("failed to init source %s: %w", sourceSpec.Name, err) | ||
| } | ||
|
|
||
| tables, err := sourceClient.GetDynamicTables(ctx) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to get dynamic tables for source %s: %w", sourceSpec.Name, err) | ||
| } | ||
|
|
||
| tableCount := len(tables.FlattenTables()) | ||
| fmt.Println("Starting migration for:", sourceSpec.Name, "->", sourceSpec.Destinations, "with", tableCount, "tables") | ||
| log.Info().Str("source", sourceSpec.Name).Strs("destinations", sourceSpec.Destinations).Msg("Starting migration") | ||
|
|
||
| for i, destinationSpec := range destinationsSpecs { | ||
| if err := destClients[i].Migrate(ctx, tables); err != nil { | ||
| return fmt.Errorf("failed to migrate source %s on destination %s : %w", sourceSpec.Name, destinationSpec.Name, err) | ||
| } | ||
| } | ||
| tt := time.Since(migrateTime) | ||
| fmt.Printf("Migration completed successfully.\n") | ||
| log.Info().Str("source", sourceSpec.Name). | ||
| Strs("destinations", sourceSpec.Destinations). | ||
| Int("num_tables", tableCount). | ||
| Float64("time_took", tt.Seconds()). | ||
| Msg("Migration completed successfully") | ||
|
|
||
| return nil | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can simplify this a bit using
status.Convert:https://discord.com/channels/872925471417962546/873606591335759872/1065556442800734268