feat(cli): Update CLI to support source v1 protocol#6986
Merged
Conversation
erezrokah
approved these changes
Jan 23, 2023
Member
erezrokah
left a comment
There was a problem hiding this comment.
Looks great, commented on the code structure mostly
| if err == nil { | ||
| return false | ||
| } | ||
| st, ok := status.FromError(err) |
Member
There was a problem hiding this comment.
We can simplify this a bit using status.Convert:
https://discord.com/channels/872925471417962546/873606591335759872/1065556442800734268
| "github.com/rs/zerolog/log" | ||
| ) | ||
|
|
||
| func migrateConnectionV0(ctx context.Context, cqDir string, sourceSpec specs.Source, destinationsSpecs []specs.Destination) error { |
Member
There was a problem hiding this comment.
Maybe we should put these in separate packages? instead of postfixing the methods something like v1/migrate and v0/migrate
Contributor
Author
There was a problem hiding this comment.
I would avoid this for now I think it will cause all things like cyclical imports but also on the CLI I don't think it should be different packages as we don't import it so it should only be on the SDK.
kodiakhq Bot
pushed a commit
that referenced
this pull request
Jan 24, 2023
🤖 I have created a release *beep* *boop* --- ## [2.3.0](cli-v2.2.0...cli-v2.3.0) (2023-01-24) ### Features * **cli:** Update CLI to support source v1 protocol ([#6986](#6986)) ([fe8ff12](fe8ff12)) * Log received signal when shutting down ([#6933](#6933)) ([7d9d8cd](7d9d8cd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready for review