Skip to content

Enable linux riscv64 builds in goreleaser - #9410

Closed
mengzhuo wants to merge 1 commit into
cli:trunkfrom
mengzhuo:patch-1
Closed

Enable linux riscv64 builds in goreleaser#9410
mengzhuo wants to merge 1 commit into
cli:trunkfrom
mengzhuo:patch-1

Conversation

@mengzhuo

@mengzhuo mengzhuo commented Aug 2, 2024

Copy link
Copy Markdown

No description provided.

@mengzhuo
mengzhuo requested a review from a team as a code owner August 2, 2024 06:15
@mengzhuo
mengzhuo requested a review from andyfeller August 2, 2024 06:15
@cliAutomation cliAutomation added the external pull request originating outside of the CLI core team label Aug 2, 2024
@cliAutomation

Copy link
Copy Markdown
Contributor

Hi! Thanks for the pull request. Please ensure that this change is linked to an issue by mentioning an issue number in the description of the pull request. If this pull request would close the issue, please put the word 'Fixes' before the issue number somewhere in the pull request body. If this is a tiny change like fixing a typo, feel free to ignore this message.

@andyfeller

andyfeller commented Aug 6, 2024

Copy link
Copy Markdown
Contributor

@mengzhuo : before any changes to the code base are made, we generally ask that issues are created to discuss changes to the product including extending official support to new distributions and CPU architectures.

The greatest challenge is what level of support can we offer given the lack of automation support for 64bit RISC-V in GitHub Actions; see actions/runner#2157 for more info.

@andyfeller andyfeller closed this Aug 6, 2024
MingcongBai added a commit to MingcongBai/cli that referenced this pull request Aug 3, 2026
Add Linux binary release targets for loong64, ppc64le, and riscv64, these
are architectures that are available both as desktop and server products.
It is also reasonable to assume that they are used by developers as host
machines, where this CLI tool would have been used.

This commit is made with the understanding that GitHub has no interest in
limiting usage of hardware of architectures other than x86, x86-64, Arm32,
and Arm64.

Given that GitHub CLI is largely an architecture-agnostic tool (at least
with its built-in functionalities), that adding binary releases is rather
trivial with GoReleaser, that Golang support is quite mature (and actively
maintained) for the three architectures above, and that i386 is still a
supported architecture where host machines of strictly 32-bit x86
architecture are likely even more obscure, so add them.

Link: cli#14012
Link: cli#9410
Link: cli#8612
Link: cli#8611
Link: cli#3615
Link: cli#1724
Signed-off-by: Mingcong Bai <jeffbai@aosc.io>
MingcongBai added a commit to MingcongBai/cli that referenced this pull request Aug 3, 2026
Add Linux binary release targets for loong64, ppc64le, and riscv64, these
are architectures that are available both as desktop and server products.
It is also reasonable to assume that they are used by developers as host
machines, where this CLI tool would have been used.

This commit is made with the understanding that GitHub has no interest in
limiting usage of hardware of architectures other than x86, x86-64, Arm32,
and Arm64.

Given that GitHub CLI is largely an architecture-agnostic tool (at least
with its built-in functionalities), that adding binary releases is rather
trivial with GoReleaser, that Golang support is quite mature (and actively
maintained) for the three architectures above, and that i386 is still a
supported architecture despite host machines of strictly 32-bit x86
architecture likely being even more obscure, so add them.

Link: cli#14012
Link: cli#8611
Link: cli#9410
Link: cli#8612
Link: cli#3615
Link: cli#1724
Signed-off-by: Mingcong Bai <jeffbai@aosc.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external pull request originating outside of the CLI core team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants