Added ppc64le support - #3615
Conversation
|
Hi! Thanks for the pull request. Please ensure that this change is linked to an issue by mentioning an issue number in the description of the pull request. If this pull request would close the issue, please put the word 'Fixes' before the issue number somewhere in the pull request body. If this is a tiny change like fixing a typo, feel free to ignore this message. |
|
Hi, would you mind explaining your contribution, i.e. elaborating on what this is useful for? I am not familiar with |
|
Sure thing! First let me clarify that I'm working for IBM to avoid any confusion :) It's not a problem to compile the binary manually, but I'd appreciate if this would be merged, because in the end these systems aren't that different from a user perspective and it would make work easier for power system users. If you have any questions or concerns don't hesitate to ask. |
|
Hi @mgiessing, thanks so much for explaining how this is used. We talked about this extensively and can't really commit to supporting this over the long term, and we aren't able to test it ourselves to know whether we've broken anything or to be able to debug going forward. Since we haven't heard feedback from others that this is something they also want supported, I'm unfortunately going to close this PR. Thanks again for the idea and apologies that we aren't able to give you a better answer. |
Add Linux binary release targets for loong64, ppc64le, and riscv64, these are architectures that are available both as desktop and server products. It is also reasonable to assume that they are used by developers as host machines, where this CLI tool would have been used. This commit is made with the understanding that GitHub has no interest in limiting usage of hardware of architectures other than x86, x86-64, Arm32, and Arm64. Given that GitHub CLI is largely an architecture-agnostic tool (at least with its built-in functionalities), that adding binary releases is rather trivial with GoReleaser, that Golang support is quite mature (and actively maintained) for the three architectures above, and that i386 is still a supported architecture where host machines of strictly 32-bit x86 architecture are likely even more obscure, so add them. Link: cli#14012 Link: cli#9410 Link: cli#8612 Link: cli#8611 Link: cli#3615 Link: cli#1724 Signed-off-by: Mingcong Bai <jeffbai@aosc.io>
Add Linux binary release targets for loong64, ppc64le, and riscv64, these are architectures that are available both as desktop and server products. It is also reasonable to assume that they are used by developers as host machines, where this CLI tool would have been used. This commit is made with the understanding that GitHub has no interest in limiting usage of hardware of architectures other than x86, x86-64, Arm32, and Arm64. Given that GitHub CLI is largely an architecture-agnostic tool (at least with its built-in functionalities), that adding binary releases is rather trivial with GoReleaser, that Golang support is quite mature (and actively maintained) for the three architectures above, and that i386 is still a supported architecture despite host machines of strictly 32-bit x86 architecture likely being even more obscure, so add them. Link: cli#14012 Link: cli#8611 Link: cli#9410 Link: cli#8612 Link: cli#3615 Link: cli#1724 Signed-off-by: Mingcong Bai <jeffbai@aosc.io>
Added ppc64le architecture support as it wasn't provided yet and shouldn't cause any problem during build due to GO's cross compilation.