Skip to content

fix(repo-edit): return error when changing visibility of a fork #13409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wahajahmed010 wants to merge 1 commit into
base: trunk
Choose a base branch
from
+15 −0
Open

fix(repo-edit): return error when changing visibility of a fork #13409

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions pkg/cmd/repo/edit/edit.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,17 @@ func NewCmdEdit(f *cmdutil.Factory, runF func(options *EditOptions) error) *cobr
return cmdutil.FlagErrorf("use of --visibility flag requires --accept-visibility-change-consequences flag")
}

if opts.Edits.Visibility != nil && !opts.InteractiveMode {
apiClient := api.NewClientFromHTTP(opts.HTTPClient)
repo, err := api.FetchRepository(apiClient, opts.Repository, []string{"isFork"})
if err != nil {
return err
}
if repo.IsFork {
return fmt.Errorf("changing visibility of a forked repository is not supported")
}
}

if opts.Edits.squashMergeCommitMsg != nil {
if opts.Edits.EnableSquashMerge == nil {
return cmdutil.FlagErrorf("--squash-merge-commit-message requires --enable-squash-merge")
Expand Down Expand Up @@ -257,6 +268,7 @@ func editRun(ctx context.Context, opts *EditOptions) error {
// TODO: GitHub Enterprise Server does not support has_discussions yet
// "hasDiscussionsEnabled",
"homepageUrl",
"isFork",
"isInOrganization",
"isTemplate",
"mergeCommitAllowed",
Expand Down Expand Up @@ -453,6 +465,9 @@ func interactiveRepoEdit(opts *EditOptions, r *api.Repository) error {
}
opts.Edits.EnableProjects = &a
case optionVisibility:
if r.IsFork {
return fmt.Errorf("changing visibility of a forked repository is not supported")
}
cs := opts.IO.ColorScheme()
fmt.Fprintf(opts.IO.ErrOut, "%s Danger zone: changing repository visibility can have unexpected consequences; consult https://gh.io/setting-repository-visibility before continuing.\n", cs.WarningIcon())

Expand Down