fix(repo-edit): return error when changing visibility of a fork#13409
Open
wahajahmed010 wants to merge 1 commit into
Open
fix(repo-edit): return error when changing visibility of a fork#13409wahajahmed010 wants to merge 1 commit into
wahajahmed010 wants to merge 1 commit into
Conversation
|
Thanks for your pull request! While it doesn't meet all of our standard requirements, it appears to be a small, focused contribution and has been routed to the team for review. Note: We still encourage linking to an issue with the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #13233.
When running
gh repo edit --visibility <value>on a forked repository, GitHub silently ignores the visibility change (since forks cannot have their visibility changed independently from the parent). Previously the CLI reported success (✓ Edited repository) even though no change was made.Changes
This PR adds validation to detect forked repositories before attempting a visibility change:
Non-interactive mode (
--visibilityflag): Before calling the API, the code now fetches theisForkfield and returns an error if the repo is a fork.Interactive mode (
gh repo edit): When the user selects "Visibility" from the menu, the code now checksisForkand returns an error before presenting visibility options.Error message:
changing visibility of a forked repository is not supportedTechnical Details
isForkto the list of fields retrieved when fetching repository info in interactive mode--accept-visibility-change-consequencescheck)interactiveRepoEdit()before presenting visibility optionsAI-assisted fix via OpenClaw subagent