You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(mosaic): match OrganizationList skeleton to the loaded list - #10608
The OrganizationList loading skeleton didn't match the loaded list. This fixes it.
Avatar bones were sized by the initials.Skeleton wrapped RowAvatar size='fit', so 100% resolved against the bone itself and the avatar shrank to its text (17px, 9px and 10px wide in swingset). Skeleton now wraps Item.Media, the same way the members-table skeleton wraps Entity.Media, so every bone is 40×40.
The personal account row was missing. The skeleton now renders it first, with a circle bone, unless hidePersonal is set, matching the view.
Rows are 52px in both the skeleton and the loaded list, so nothing shifts on swap.
Before
After
Checklist
pnpm test runs as expected.
pnpm build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
No actionable comments were generated in the recent review.
Walkthrough
OrganizationListSkeleton now shows a personal-account placeholder unless hidePersonal is set. Organization placeholders use a shared row helper that renders a circular or square avatar shape and the supplied name. A patch changeset describes the skeleton updates.
clerk/javascript#10502: Introduced OrganizationList and its original skeleton, which this change updates.
clerk/javascript#10600: Changes the shared Item.Media column size used by the skeleton’s avatar sizing.
Suggested reviewers:kylemac, austincalvelage
Merge Risk: Minimal · up to ca1d6
The loading placeholders are intended to match the loaded list. No merge-blocking issue was identified.
Pre-merge checks: 4 · 1
Failed checks: 1 warning
Check name
Status
Explanation
Resolution
Docstring Coverage
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed checks: 4 passed
Check name
Status
Explanation
Title check
The title names the main change: the OrganizationList loading skeleton is changed to match the loaded list. It uses the fix(mosaic) prefix and names the affected component. The changeset supports this…
Description check
The description is related to the changeset. It explains that the OrganizationList loading skeleton did not match the loaded list. It says Skeleton now wraps Item.Media so avatar bones are 40x40. It s…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the main change: the OrganizationList loading skeleton is changed to match the loaded list. It uses the fix(mosaic) prefix and names the affected component. The changeset supports this. The skeleton now sizes avatar placeholders to the loaded avatar size and renders the personal account row unless hidePersonal is set.
Full details: Description check
Explanation
The description is related to the changeset. It explains that the OrganizationList loading skeleton did not match the loaded list. It says Skeleton now wraps Item.Media so avatar bones are 40x40. It says the skeleton renders a personal account row with a circle bone unless hidePersonal is set. It also includes before and after screenshots.
Full details: Docstring Coverage
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 2 functions across 1 files. (1 skipped: 1 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Linked repositories: Some configured repositories could not be included in this review. Cross-repository analysis may be incomplete. Please check linked-repository access and settings.
CodeRabbit Verify
Run CodeRabbit Verify to test the changes in this pull request.
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 2 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
OrganizationListloading skeleton didn't match the loaded list. This fixes it.SkeletonwrappedRowAvatar size='fit', so100%resolved against the bone itself and the avatar shrank to its text (17px, 9px and 10px wide in swingset).Skeletonnow wrapsItem.Media, the same way the members-table skeleton wrapsEntity.Media, so every bone is 40×40.hidePersonalis set, matching the view.Rows are 52px in both the skeleton and the loaded list, so nothing shifts on swap.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change