Repository navigation
Fix bug in 'flatten releases' function where 'none' release types don't play nicely with other release types #693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Andarist
merged 6 commits into
changesets:main
from
luciaquirke:fix-none-type-release-flatten
Jan 24, 2022
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
913b2eb
Fix how changesets are flattened by including none types and simplify…
965af44
Test flattening 'none' changesets with other changesets
b6d7d0b
Add changeset
6b95d07
Lint change
0a19a68
Merge branch 'main' into fix-none-type-release-flatten
luciaquirke debcfea
Apply suggestions from code review
Andarist File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add changeset
- Loading branch information
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@changesets/assemble-release-plan": patch | ||
|
Andarist marked this conversation as resolved.
Resolved
|
||
| --- | ||
|
|
||
| Fix flatten-releases so 'none' release types don't override other release types | ||
|
Andarist marked this conversation as resolved.
Resolved
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
q: is only this package affected? or is the CLI affected too? or maybe is this problem "fixed up" in some other part of the code when CLI runs end to end?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the bug is fixed up anywhere because we found some packages in production that hadn't been bumped as a result of this bug. The CLI is affected because it calls @changesets/assemble-release-plan.