Repository navigation
Fix bug in 'flatten releases' function where 'none' release types don't play nicely with other release types - #693
Conversation
🦋 Changeset detectedLatest commit: debcfea The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| setup.addChangeset({ | ||
| id: "big-cats-yelp", | ||
| releases: [ | ||
| { name: "pkg-a", type: "none" }, | ||
| { name: "pkg-b", type: "none" }, | ||
| { name: "pkg-c", type: "none" } | ||
| ] |
There was a problem hiding this comment.
in a way, this part is not really required for this test, but I guess it doesn't hurt it
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@changesets/assemble-release-plan": patch | |||
There was a problem hiding this comment.
q: is only this package affected? or is the CLI affected too? or maybe is this problem "fixed up" in some other part of the code when CLI runs end to end?
There was a problem hiding this comment.
I don't think the bug is fixed up anywhere because we found some packages in production that hadn't been bumped as a result of this bug. The CLI is affected because it calls @changesets/assemble-release-plan.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit debcfea:
|
Patch/minor/major releases can be overridden by none releases during the 'assemble release plan' stage of
changeset version, making package versions fail to be bumped.The fix consists of handling the 'none' release type in the
flatten-releasesfunction, and slightly simplifying the logic.