Remove initialVersions in pre.json - #2117
Conversation
🦋 Changeset detectedLatest commit: 105f2d9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2117 +/- ##
==========================================
- Coverage 85.52% 85.42% -0.11%
==========================================
Files 66 66
Lines 2535 2538 +3
Branches 700 700
==========================================
Hits 2168 2168
- Misses 337 340 +3
Partials 30 30 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| // "initialVersions" is not used for a long time, so can directly delete | ||
| delete preState.initialVersions; | ||
|
|
||
| await outputFile( |
There was a problem hiding this comment.
it would be nice to use the editJson here, but given this is like a one-time migration... we probably don't have to
There was a problem hiding this comment.
Yeah it'd be nice to reuse that, but we need to figure out how to share it and also needs an update to handle deletions. Let's see if people are getting formatting issues if we do something like this.
#2110 but standalone to main
I've also ported the auto-migration on
readPreState, but if we have concerns of this we can also not do this as leaving the property there as is is harmless. The next time they start prerelease with changesets v3, it won't be there anymore.