Remove initialVersions in pre.json - #2110
Closed
bluwy wants to merge 2 commits into
Closed
Conversation
🦋 Changeset detectedLatest commit: 187ff13 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## pre-no-changeset #2110 +/- ##
====================================================
- Coverage 84.95% 84.83% -0.13%
====================================================
Files 66 66
Lines 2526 2525 -1
Branches 696 696
====================================================
- Hits 2146 2142 -4
- Misses 350 351 +1
- Partials 30 32 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Andarist
approved these changes
Jun 23, 2026
Comment on lines
+84
to
+95
| // "changesets" is not used by v3 anymore, delete and remove the stale changeset files | ||
| if (preState.changesets != null) { | ||
| for (const changesetId of preState.changesets) { | ||
| await fs | ||
| .rm(path.resolve(rootDir, ".changeset", changesetId + ".md")) | ||
| .catch(() => { | ||
| // It's possible to specify an unknown id before without errors, so we | ||
| // don't throw an error here if the file doesn't exist. | ||
| }); | ||
| } | ||
| delete preState.changesets; | ||
| } |
Member
There was a problem hiding this comment.
isn't this just to handle some old versions too? perhaps this block could also be removed entirely?
Member
There was a problem hiding this comment.
oh wait, this PR is stacked on top of #2109 (which I have not noticed initially)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unused since #454