Repository navigation
Update and align @types/jest with jest runtime and remove ts-ignores - #1467
marcalexiei wants to merge 3 commits into
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1467 +/- ##
=======================================
Coverage 81.04% 81.04%
=======================================
Files 54 54
Lines 2221 2221
Branches 657 662 +5
=======================================
Hits 1800 1800
Misses 417 417
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c221fb0 to
1d7873f
Compare
bluwy
left a comment
There was a problem hiding this comment.
The refactor for mock types looks really good. I've noticed some imports shifted around, do you mind putting the order back to reduce the diff? (I've noted them in the comments below)
Mainly this will help merging future changes that we're working on in the next branch. Thanks!
1d7873f to
5308b31
Compare
marcalexiei
left a comment
There was a problem hiding this comment.
Requested file imports have been reverted to their original order
|
One last thing from the description: |
|
I'm not the main maintainer around here, but I'd say go ahead! Maybe it's better to send the PR first and merge that first? So we don't have a short timeframe where we have to use skipLibCheck. The other maintainers may have opinions about |
e514f3f to
51be97d
Compare
51be97d to
31f064a
Compare
|
I rechecked the type errors and adding Lines 2016 to 2019 in 7ccb22e So now there is no need to use |
This comment was marked as outdated.
This comment was marked as outdated.
|
I noticed that If you prefer we can merge this PR into |
bluwy
left a comment
There was a problem hiding this comment.
You don't need to re-request review if there isn't any significant code change. It'll also be easier to review what changed if you push a new commit instead of force pushing.
jestand@types/jesthave been updated to the latest version (29.7.0)Previously the types version wasn't matching the runtime version
@ts-ignore@ts-ignorethat were no longer valid@ts-ignorethat cannot be removed have been replaced with@ts-expect-errordirective followed by an explanation#1467 (comment)