Skip to content

Set release date instead of modification date #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josemduarte merged 2 commits into from
Jul 8, 2017
Merged

Set release date instead of modification date #685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b21a283
Removed misleading comment
pwrose Jul 6, 2017
f35d972
Populate release date instead of modification date.
pwrose Jul 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion biojava-structure/src/main/java/org/biojava/nbio/structure/io/mmcif/SimpleMMcifConsumer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1467,7 +1467,6 @@ public void newPdbxDatabaseStatus(PdbxDatabaseStatus status) {
header = new PDBHeader();
}

// first entry in revision history is the release date
try {
Date depositionDate = dateFormat.parse(status.getRecvd_initial_deposition_date());
header.setDepDate(depositionDate);
Expand Down
7 changes: 3 additions & 4 deletions biojava-structure/src/main/java/org/biojava/nbio/structure/io/mmtf/MmtfStructureReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,14 +506,13 @@ public void setHeaderInfo(float rFree, float rWork, float resolution, String tit
if(releaseDate!=null){
try {
Date relDate = formatter.parse(releaseDate);
pdbHeader.setModDate(relDate);
pdbHeader.setRelDate(relDate);
} catch (ParseException e) {
logger.warn("Could not parse date string '{}', release/modification date will be unavailable", releaseDate);
logger.warn("Could not parse date string '{}', release date will be unavailable", releaseDate);
}
}
else{
pdbHeader.setModDate(new Date(0));
pdbHeader.setRelDate(new Date(0));
}

}
}