Skip to content

Set release date instead of modification date#685

Merged
josemduarte merged 2 commits into
biojava:masterfrom
pwrose:master
Jul 8, 2017
Merged

Set release date instead of modification date#685
josemduarte merged 2 commits into
biojava:masterfrom
pwrose:master

Conversation

@pwrose
Copy link
Copy Markdown
Member

@pwrose pwrose commented Jul 6, 2017

No description provided.

@josemduarte
Copy link
Copy Markdown
Contributor

josemduarte commented Jul 6, 2017

It seems that the build is failing because of a combination of an old JVM version in Travis plus the RCSB PDB certificates having changed recently (last week). At least this is what I gathered from this post: https://bitbucket.org/versioneye/versioneye/issues/276/ssl-certificate-issues-when-using-maven

It looks like Travis is using a rather old JVM and it doesn't seem possible to change that.

@josemduarte
Copy link
Copy Markdown
Contributor

josemduarte commented Jul 6, 2017

We've seen this kind of failures in all the latest pull requests in master. Running locally on an Ubuntu box with latest JVM all works fine.

@josemduarte
Copy link
Copy Markdown
Contributor

josemduarte commented Jul 6, 2017

By the way the error message looks like this (from Travis logs):

Running org.biojava.nbio.structure.io.mmtf.TestMmtfPerformance
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 3.256 sec <<< FAILURE! - in org.biojava.nbio.structure.io.mmtf.TestMmtfPerformance
test3HBX(org.biojava.nbio.structure.io.mmtf.TestMmtfPerformance)  Time elapsed: 1.488 sec  <<< ERROR!
javax.net.ssl.SSLHandshakeException: sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target
	at org.biojava.nbio.structure.io.mmtf.TestMmtfPerformance.test3HBX(TestMmtfPerformance.java:104)
Caused by: sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target
	at org.biojava.nbio.structure.io.mmtf.TestMmtfPerformance.test3HBX(TestMmtfPerformance.java:104)
Caused by: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target
	at org.biojava.nbio.structure.io.mmtf.TestMmtfPerformance.test3HBX(TestMmtfPerformance.java:104)

That's the same as @lafita observed in his latest PR

lafita
lafita approved these changes Jul 7, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@lafita lafita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look ok to me!

@josemduarte
Copy link
Copy Markdown
Contributor

josemduarte commented Jul 8, 2017

I'll merge this, since tests work fine locally.

@josemduarte josemduarte merged commit 84c5617 into biojava:master Jul 8, 2017
@josemduarte
Copy link
Copy Markdown
Contributor

josemduarte commented Jul 8, 2017

Regarding the SSL JVM problems, I've tried changing travis configuration to use openjdk8 but that's not supported yet despite what their docs say: https://docs.travis-ci.com/user/languages/java/

@josemduarte
Copy link
Copy Markdown
Contributor

josemduarte commented Jul 8, 2017

I've finally managed to fix the outdated JVM problem in travis by using the sudo: required environment. Found the solution in this post: travis-ci/travis-ci#3259. Tests should be working now.

@pwrose
Copy link
Copy Markdown
Member Author

pwrose commented Jul 8, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lafita lafita lafita approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pwrose @josemduarte @lafita