Skip to content

Fix FastaStreamerTest tests failing on windows due to URL handling #1093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josemduarte merged 2 commits into from
Apr 26, 2024
+8 −6
Merged

Fix FastaStreamerTest tests failing on windows due to URL handling #1093

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1964040
Use toURI instead of getFile which doesn't have file scheme
cometbroom Apr 24, 2024
d96cae4
Reverting changes to pom files
cometbroom Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions biojava-core/src/test/java/org/biojava/nbio/core/sequence/io/FastaStreamerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
import org.junit.Test;

import java.io.IOException;
import java.net.URI;
import java.net.URISyntaxException;
import java.nio.file.Path;
import java.nio.file.Paths;
import java.util.List;
Expand All @@ -16,9 +18,9 @@
public class FastaStreamerTest {

@Test
public void stream() throws IOException {
String file = this.getClass().getResource("PF00104_small.fasta.gz").getFile();
Path path = Paths.get(file);
public void stream() throws IOException, URISyntaxException {
URI fileUri = this.getClass().getResource("PF00104_small.fasta.gz").toURI();
Path path = Paths.get(fileUri);
List<ProteinSequence> sequences;

sequences = FastaStreamer.from(path).stream().collect(Collectors.toList());
Expand All @@ -38,9 +40,9 @@ public void stream() throws IOException {
}

@Test
public void iterate() {
String file = this.getClass().getResource("PF00104_small.fasta.gz").getFile();
Path path = Paths.get(file);
public void iterate() throws URISyntaxException {
URI fileUri = this.getClass().getResource("PF00104_small.fasta.gz").toURI();
Path path = Paths.get(fileUri);
int count = 0;
for (ProteinSequence sequence : FastaStreamer.from(path).each()) {
count++;
Expand Down