Fix FastaStreamerTest tests failing on windows due to URL handling - #1093
Merged
Conversation
josemduarte
approved these changes
Apr 24, 2024
josemduarte
left a comment
Contributor
There was a problem hiding this comment.
Thanks, LGTM. Did you manage to test this in windows?
One thing only: could you revert the changes to the pom files? Those shouldn't be needed. We'll increment versions at next release automatically.
Contributor
Author
|
@josemduarte Yes all tests passed successfully on windows. Also reverted changes to pom files. My bad, missed that part. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #1092 :
When getting a resource with the, getFile() method. It does not contain the scheme of the resource you're trying to access. That is needed by Paths.get() to create a path appropriate for Windows file system.
The url returned by getFile() would be "C:/Users/etc" while it needs to be "file:/C:/Users/etc"