Skip to content

Allow for custom python versions in python_register_toolchains #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
f0rmiga merged 1 commit into from
Mar 15, 2022
Merged

Allow for custom python versions in python_register_toolchains #657

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion python/repositories.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,6 @@ python_repository = repository_rule(
"python_version": attr.string(
doc = "The Python version.",
mandatory = True,
values = TOOL_VERSIONS.keys() + MINOR_MAPPING.keys(),

@mattem mattem Mar 16, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there should still be some validation here, but instead now in the macro. Can this be added in a follow up diff?

),
"release_filename": attr.string(
doc = "The filename of the interpreter to be downloaded",
Expand Down