Allow for custom python versions in python_register_toolchains - #657
Merged
Conversation
UebelAndre
marked this pull request as ready for review
March 15, 2022 22:22
f0rmiga
approved these changes
Mar 15, 2022
mattem
reviewed
Mar 16, 2022
| "python_version": attr.string( | ||
| doc = "The Python version.", | ||
| mandatory = True, | ||
| values = TOOL_VERSIONS.keys() + MINOR_MAPPING.keys(), |
Contributor
There was a problem hiding this comment.
I think there should still be some validation here, but instead now in the macro. Can this be added in a follow up diff?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
If you define your own
python_register_toolchains.tool_versionsfor a version that is not a built in version, then the repository rule rejects it.Issue Number: N/A
What is the new behavior?
This change allows users to define custom python versions that are not already registered in
@rules_python//python:versions.bzl.Does this PR introduce a breaking change?
Other information